[Backport 2.x] [Data Explorer][Discover 2.0] Fix issues when change index pattern #4885

opensearch-trigger-bot · 2023-08-31T22:44:59Z

Backport 9958799 from #4875.

…4875) * allow side nav show only selected index pattern fields when switch * allow reset column state when switch index pattern Issue Resolve: #4840 #4846 Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 9958799) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

codecov · 2023-08-31T23:02:31Z

Codecov Report

Merging #4885 (f439da6) into 2.x (96af535) will increase coverage by 0.00%.
Report is 1 commits behind head on 2.x.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              2.x    #4885   +/-   ##
=======================================
  Coverage   66.44%   66.44%           
=======================================
  Files        3396     3397    +1     
  Lines       64847    64850    +3     
  Branches    10356    10357    +1     
=======================================
+ Hits        43088    43091    +3     
  Misses      19202    19202           
  Partials     2557     2557

Flag	Coverage Δ
Linux_1	`34.91% <ø> (ø)`
Linux_2	`55.18% <ø> (ø)`
Linux_3	`44.20% <100.00%> (+<0.01%)`	⬆️
Linux_4	`35.08% <ø> (ø)`
Windows_1	`34.93% <ø> (ø)`
Windows_2	`55.15% <ø> (ø)`
Windows_3	`44.20% <100.00%> (+<0.01%)`	⬆️
Windows_4	`35.08% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...pplication/view_components/utils/filter_columns.ts	`100.00% <100.00%> (ø)`

…ttern (opensearch-project#4875) (opensearch-project#4885)" This reverts commit 0102a32. try revert:

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

@param

…CH (#5508) (#5746) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

@param

…CH (#5508) (#5638) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

opensearch-trigger-bot bot requested review from ananzh, kavilla, seanneumann, AMoo-Miki, ashwin-pc and joshuarrrr as code owners August 31, 2023 22:44

opensearch-trigger-bot bot added discover for discover reinvent autocut Skip the changelog verification check on backports labels Aug 31, 2023

opensearch-trigger-bot bot requested a review from abbyhu2000 as a code owner August 31, 2023 22:45

opensearch-trigger-bot bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry distinguished-contributor labels Aug 31, 2023

opensearch-trigger-bot bot requested a review from zengyan-amazon as a code owner August 31, 2023 22:45

opensearch-trigger-bot bot added the data explorer Issues related to the Data Explorer project label Aug 31, 2023

opensearch-trigger-bot bot requested a review from kristenTian as a code owner August 31, 2023 22:45

opensearch-trigger-bot bot added the v2.10.0 label Aug 31, 2023

opensearch-trigger-bot bot requested review from zhongnansu, manasvinibs, ZilongX, Flyingliuhub and BSFishy as code owners August 31, 2023 22:45

joshuarrrr approved these changes Sep 1, 2023

View reviewed changes

AMoo-Miki approved these changes Sep 1, 2023

View reviewed changes

AMoo-Miki merged commit 0102a32 into 2.x Sep 1, 2023
77 of 79 checks passed

github-actions bot deleted the backport/backport-4875-to-2.x branch September 1, 2023 19:05

MadaniKK added a commit to MadaniKK/OpenSearch-Dashboards that referenced this pull request Nov 18, 2023

Revert "[Data Explorer][Discover 2.0] Fix issues when change index pa…

9f7d04a

…ttern (opensearch-project#4875) (opensearch-project#4885)" This reverts commit 0102a32. try revert:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 2.x] [Data Explorer][Discover 2.0] Fix issues when change index pattern #4885

[Backport 2.x] [Data Explorer][Discover 2.0] Fix issues when change index pattern #4885

opensearch-trigger-bot bot commented Aug 31, 2023

codecov bot commented Aug 31, 2023 •

edited

Loading

[Backport 2.x] [Data Explorer][Discover 2.0] Fix issues when change index pattern #4885

[Backport 2.x] [Data Explorer][Discover 2.0] Fix issues when change index pattern #4885

Conversation

opensearch-trigger-bot bot commented Aug 31, 2023

codecov bot commented Aug 31, 2023 • edited Loading

Codecov Report

codecov bot commented Aug 31, 2023 •

edited

Loading