-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deangular] Fixes search on load #5096
Closed
ashwin-pc
wants to merge
6
commits into
opensearch-project:feature/deangular
from
ashwin-pc:fix/search-on-load
Closed
[Deangular] Fixes search on load #5096
ashwin-pc
wants to merge
6
commits into
opensearch-project:feature/deangular
from
ashwin-pc:fix/search-on-load
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
…search-project#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve opensearch-project#4233 --------- Signed-off-by: ananzh <ananzh@amazon.com>
…pensearch-project#5060) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
…ject#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove discover folder in config file Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
ashwin-pc
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
September 22, 2023 22:33
Codecov Report
@@ Coverage Diff @@
## feature/deangular #5096 +/- ##
=====================================================
+ Coverage 66.49% 66.69% +0.20%
=====================================================
Files 3403 3283 -120
Lines 65023 63059 -1964
Branches 10401 10031 -370
=====================================================
- Hits 43235 42058 -1177
+ Misses 19225 18542 -683
+ Partials 2563 2459 -104
Flags with carried forward coverage won't be shown. Click here to find out more.
|
abbyhu2000
force-pushed
the
feature/deangular
branch
from
September 22, 2023 22:54
f14c199
to
e6b9ab2
Compare
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the setting
searchOnPageLoad
Issues Resolved
fixes #5057
Screenshot
Screen.Recording.2023-09-25.at.3.21.35.PM.mov
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr