Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deangular] Fixes search on load #5096

Conversation

ashwin-pc
Copy link
Member

@ashwin-pc ashwin-pc commented Sep 22, 2023

Description

Fixes the setting searchOnPageLoad

Issues Resolved

fixes #5057

Screenshot

Screen.Recording.2023-09-25.at.3.21.35.PM.mov

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

ashwin-pc and others added 5 commits September 14, 2023 01:27
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
…search-project#5081)

* [Data Explorer][Discover 2.0] Implement saved search embeddable

Issue Resolve
opensearch-project#4233

---------

Signed-off-by: ananzh <ananzh@amazon.com>
…ject#5088)

* delete legacy discover functional tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* remove discover folder in config file

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #5096 (f1c2af9) into feature/deangular (a925581) will increase coverage by 0.20%.
Report is 14 commits behind head on feature/deangular.
The diff coverage is 0.00%.

❗ Current head f1c2af9 differs from pull request most recent head cf28df2. Consider uploading reports for the commit cf28df2 to get more accurate results

@@                  Coverage Diff                  @@
##           feature/deangular    #5096      +/-   ##
=====================================================
+ Coverage              66.49%   66.69%   +0.20%     
=====================================================
  Files                   3403     3283     -120     
  Lines                  65023    63059    -1964     
  Branches               10401    10031     -370     
=====================================================
- Hits                   43235    42058    -1177     
+ Misses                 19225    18542     -683     
+ Partials                2563     2459     -104     
Flag Coverage Δ
Linux_1 35.25% <0.00%> (+0.43%) ⬆️
Linux_2 55.23% <ø> (-0.08%) ⬇️
Linux_3 43.66% <ø> (-0.95%) ⬇️
Linux_4 35.43% <ø> (+0.54%) ⬆️
Windows_1 35.27% <0.00%> (?)
Windows_2 55.20% <ø> (-0.08%) ⬇️
Windows_3 43.66% <ø> (-0.95%) ⬇️
Windows_4 35.43% <ø> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/osd-ui-shared-deps/index.js 100.00% <ø> (ø)
src/plugins/dashboard/public/plugin.tsx 0.00% <ø> (ø)
...ugins/data/common/search/aggs/utils/prop_filter.ts 100.00% <ø> (ø)
...s/data/common/search/aggs/utils/to_angular_json.ts 0.00% <ø> (ø)
src/plugins/discover/common/index.ts 100.00% <ø> (ø)
...rc/plugins/discover/public/embeddable/constants.ts 100.00% <ø> (ø)
src/plugins/discover/public/index.ts 0.00% <ø> (ø)
...ugins/opensearch_dashboards_legacy/public/index.ts 50.00% <ø> (ø)
src/plugins/discover/public/build_services.ts 0.00% <0.00%> (ø)
...er/public/embeddable/search_embeddable_factory.tsx 0.00% <0.00%> (ø)
... and 1 more

... and 9 files with indirect coverage changes

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc mentioned this pull request Sep 25, 2023
8 tasks
@ashwin-pc ashwin-pc closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants