Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Add long numerals support #5592

Merged
merged 3 commits into from
Jan 10, 2024

Merge branch 'main' into fix-discover-long-numerals

55c47a5
Select commit
Loading
Failed to load commit list.
Merged

[Discover] Add long numerals support #5592

Merge branch 'main' into fix-discover-long-numerals
55c47a5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2024 in 1s

67.02% (+0.00%) compared to bf5e842

View this Pull Request on Codecov

67.02% (+0.00%) compared to bf5e842

Details

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (bf5e842) 67.02% compared to head (55c47a5) 67.02%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/core/server/http/router/response_adapter.ts 0.00% 1 Missing and 2 partials ⚠️
...omponents/data_grid/data_grid_table_cell_value.tsx 40.00% 2 Missing and 1 partial ⚠️
src/core/public/ui_settings/ui_settings_client.ts 50.00% 0 Missing and 1 partial ⚠️
...ns/data/common/field_formats/converters/numeral.ts 66.66% 0 Missing and 1 partial ⚠️
...c/plugins/data/public/search/search_interceptor.ts 83.33% 0 Missing and 1 partial ⚠️
...c/ui/filter_bar/filter_editor/lib/filter_label.tsx 0.00% 1 Missing ⚠️
...a/server/search/opensearch_search/decide_client.ts 50.00% 0 Missing and 1 partial ⚠️
...lic/saved_object/helpers/serialize_saved_object.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5592   +/-   ##
=======================================
  Coverage   67.02%   67.02%           
=======================================
  Files        3294     3294           
  Lines       63307    63318   +11     
  Branches    10071    10083   +12     
=======================================
+ Hits        42432    42440    +8     
- Misses      18430    18432    +2     
- Partials     2445     2446    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov