[Bug][Discover] Allow saved sort from search embeddable to load in Dashboard

[ananzh]

Description

Remove default sort to use saved search sort.

Issues Resolved

#5933

Screenshot

save.mov

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.00%. Comparing base (d56b04d) to head (16f5329).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5934   +/-   ##
=======================================
  Coverage   67.00%   67.00%           
=======================================
  Files        3307     3307           
  Lines       63614    63614           
  Branches    10163    10163           
=======================================
  Hits        42627    42627           
  Misses      18518    18518           
  Partials     2469     2469           

Flag	Coverage Δ
Linux_1	35.21% <ø> (ø)
Linux_2	55.09% <ø> (ø)
Linux_3	43.63% <ø> (+0.01%)	⬆️
Linux_4	35.20% <ø> (ø)
Windows_1	35.24% <ø> (ø)
Windows_2	55.06% <ø> (ø)
Windows_3	43.63% <ø> (ø)
Windows_4	35.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ashwin-pc]

Would be nice if we had a test for this.

[seraphjiang]

Would be nice if we had a test for this.

I'm curious to know why it is nice not required to have test? just want to be sure we could maintain same quality bar

cc: @wbeckler @AMoo-Miki @zengyan-amazon

[ananzh]

discover-sort.mov

[ashwin-pc]

@seraphjiang you are right, this is not a nice to have test, but a required one. @ananzh can you as a followup to this PR add a test for this scenario?

My original hesitation was because I was worried that we would be adding testing here for testing sake. But that is an unnecessary worry.

[seraphjiang]

Thanks @ashwin-pc for clarification.
I also agree not necessary adding testing for testing sake. as long as we have a way to ensure quality. the test could be added in follow up issue/PR.

[ananzh]

@ashwin-pc @seraphjiang Yes, we do have a meta issue to create more tests for discover #5713.
The section Function Test Suite 6: Saved Search Embeddable in Dashboard is the one to track. I have create an issue for this section and label it. Will work on it.