[Discover] options button in canvas to toggle legacy mode #6170

kavilla · 2024-03-16T03:20:22Z

Description

Removes top nav bar link and provides a button option.

Issues Resolved

n/a

Screenshot

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2024-03-16T03:33:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.24%. Comparing base (bfab07c) to head (ee4381b).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6170      +/-   ##
==========================================
+ Coverage   67.22%   67.24%   +0.02%     
==========================================
  Files        3344     3344              
  Lines       64796    64796              
  Branches    10427    10427              
==========================================
+ Hits        43556    43572      +16     
+ Misses      18697    18683      -14     
+ Partials     2543     2541       -2

Flag	Coverage Δ
Linux_1	`31.64% <ø> (ø)`
Linux_2	`55.45% <ø> (ø)`
Linux_3	`44.69% <ø> (ø)`
Linux_4	`35.06% <ø> (ø)`
Windows_1	`31.67% <ø> (?)`
Windows_2	`55.41% <ø> (ø)`
Windows_3	`44.70% <ø> (?)`
Windows_4	`35.06% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/plugins/discover/public/application/view_components/canvas/index.tsx

kavilla · 2024-03-18T17:09:24Z

@kgcreative what do you think about this?

kgcreative · 2024-03-18T17:52:37Z

@kavilla If we're able to align the button top-right instead of top-left, i think that's more consistent with other places where we do additional actions, but that's a minor nice-to-have

kavilla · 2024-03-18T19:59:11Z

@kavilla If we're able to align the button top-right instead of top-left, i think that's more consistent with other places where we do additional actions, but that's a minor nice-to-have

like this @kgcreative?:

Update tests related to switching from legacy view within the Discover page. Requires: opensearch-project/OpenSearch-Dashboards#6170 Signed-off-by: Kawika Avilla <avillk@amazon.com>

github-actions · 2024-03-19T00:41:18Z

[MANUAL CYPRESS TEST RUN RESULTS]

✅ Cypress test run succeeded!

Inputs:

Test repo: 'kavilla/opensearch-dashboards-functional-test'
Test branch: 'kavilla/discover/toggle'

Test spec:
''

Link to results:

https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/8335506987

Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [Discover] options button in canvas to toggle legacy mode Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit db9806d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

Update tests related to switching from legacy view within the Discover page. Requires: opensearch-project/OpenSearch-Dashboards#6170 Signed-off-by: Kawika Avilla <avillk@amazon.com> Co-authored-by: Kawika Avilla <avillk@amazon.com>

Update tests related to switching from legacy view within the Discover page. Requires: opensearch-project/OpenSearch-Dashboards#6170 Signed-off-by: Kawika Avilla <avillk@amazon.com> Co-authored-by: Kawika Avilla <avillk@amazon.com> (cherry picked from commit 6a551e8)

) * [Discover] options button in canvas to toggle legacy mode Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit db9806d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Update tests related to switching from legacy view within the Discover page. Requires: opensearch-project/OpenSearch-Dashboards#6170 Signed-off-by: Kawika Avilla <avillk@amazon.com> Co-authored-by: Kawika Avilla <avillk@amazon.com> (cherry picked from commit 6a551e8) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>

…-project#6170) * [Discover] options button in canvas to toggle legacy mode Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla requested review from ananzh, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, BSFishy, curq, bandinib-amzn, SuZhou-Joe, ruanyl and BionIT as code owners March 16, 2024 03:20

github-actions bot added the distinguished-contributor label Mar 16, 2024

kavilla added backport 2.x discover for discover reinvent v2.13.0 labels Mar 16, 2024

ashwin-pc previously approved these changes Mar 16, 2024

View reviewed changes

kavilla dismissed ashwin-pc’s stale review via 2fefd2f March 16, 2024 07:22

kavilla mentioned this pull request Mar 16, 2024

[Discover] toggle for legacy mode opensearch-project/opensearch-dashboards-functional-test#1148

Merged

1 task

kavilla force-pushed the kavilla/legacy_toggle branch from 51f0c73 to 1929924 Compare March 16, 2024 15:30

ruanyl previously approved these changes Mar 18, 2024

View reviewed changes

src/plugins/discover/public/application/view_components/canvas/index.tsx Show resolved Hide resolved

kavilla dismissed ruanyl’s stale review via 33a3fba March 18, 2024 13:40

kavilla mentioned this pull request Mar 19, 2024

[Discover] update tests related to legacy view opensearch-project/opensearch-dashboards-functional-test#1155

Merged

1 task

opensearch-project deleted a comment from github-actions bot Mar 19, 2024

kavilla added 12 commits March 19, 2024 00:56

[Discover] options button in canvas to toggle legacy mode

38181f1

Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

update changelog

5bd6056

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Update tests

9432bb9

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Use only 1 layer for options and fix storage

213e6ee

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

capitalization

f12c40a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

update snapshot

45d05a6

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

update snapshot without plugins

68633c7

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

fix test for time range to show options

dfad75f

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

update test

6fd48aa

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

fix test for filter

500a83f

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

update scripted fields

5915f05

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

move to top right

ee4381b

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla force-pushed the kavilla/legacy_toggle branch from c10d195 to ee4381b Compare March 19, 2024 00:57

abbyhu2000 approved these changes Mar 19, 2024

View reviewed changes

ashwin-pc approved these changes Mar 19, 2024

View reviewed changes

ruanyl approved these changes Mar 19, 2024

View reviewed changes

kavilla merged commit db9806d into opensearch-project:main Mar 19, 2024
64 of 68 checks passed

opensearch-trigger-bot bot mentioned this pull request Mar 19, 2024

[Backport 2.x] [Discover] options button in canvas to toggle legacy mode #6191

Merged

Tostti mentioned this pull request Apr 4, 2024

Compatibility with OpenSearch v2.13.0 wazuh/wazuh-dashboard#161

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] options button in canvas to toggle legacy mode #6170

[Discover] options button in canvas to toggle legacy mode #6170

kavilla commented Mar 16, 2024 •

edited

Loading

codecov bot commented Mar 16, 2024 •

edited

Loading

kavilla commented Mar 18, 2024

kgcreative commented Mar 18, 2024

kavilla commented Mar 18, 2024 •

edited

Loading

github-actions bot commented Mar 19, 2024

[Discover] options button in canvas to toggle legacy mode #6170

[Discover] options button in canvas to toggle legacy mode #6170

Conversation

kavilla commented Mar 16, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Check List

codecov bot commented Mar 16, 2024 • edited Loading

Codecov Report

kavilla commented Mar 18, 2024

kgcreative commented Mar 18, 2024

kavilla commented Mar 18, 2024 • edited Loading

github-actions bot commented Mar 19, 2024

[MANUAL CYPRESS TEST RUN RESULTS]

✅ Cypress test run succeeded!

Inputs:

Link to results:

kavilla commented Mar 16, 2024 •

edited

Loading

codecov bot commented Mar 16, 2024 •

edited

Loading

kavilla commented Mar 18, 2024 •

edited

Loading