Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] toggle for legacy mode #1148

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 16, 2024

Description

Address changes from: opensearch-project/OpenSearch-Dashboards#6170

Issues Resolved

n/a

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kawika Avilla <avillk@amazon.com>
@ananzh
Copy link
Member

ananzh commented Mar 17, 2024

@kavilla lint checker failed. could you fix this?

@ananzh ananzh self-requested a review March 17, 2024 06:07
Kawika Avilla added 2 commits March 18, 2024 10:04
Signed-off-by: Kawika Avilla <avillk@amazon.com>
Signed-off-by: Kawika Avilla <avillk@amazon.com>
Signed-off-by: Kawika Avilla <avillk@amazon.com>
@ananzh ananzh merged commit 861f8b2 into opensearch-project:main Mar 18, 2024
38 of 42 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 18, 2024
* [Discover] toggle for legacy mode
* remove async
* invert boolean

---------

Signed-off-by: Kawika Avilla <avillk@amazon.com>
Co-authored-by: Kawika Avilla <avillk@amazon.com>
(cherry picked from commit 861f8b2)
ananzh pushed a commit that referenced this pull request Mar 18, 2024
* [Discover] toggle for legacy mode
* remove async
* invert boolean

---------

Signed-off-by: Kawika Avilla <avillk@amazon.com>
Co-authored-by: Kawika Avilla <avillk@amazon.com>
(cherry picked from commit 861f8b2)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
kavilla pushed a commit to kavilla/opensearch-dashboards-functional-test that referenced this pull request Mar 18, 2024
kavilla pushed a commit to kavilla/opensearch-dashboards-functional-test that referenced this pull request Mar 18, 2024
This reverts commit 861f8b2.

Signed-off-by: Kawika Avilla <avillk@amazon.com>
kavilla added a commit that referenced this pull request Mar 18, 2024
This reverts commit 861f8b2.

Signed-off-by: Kawika Avilla <avillk@amazon.com>
Co-authored-by: Kawika Avilla <avillk@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 18, 2024
This reverts commit 861f8b2.

Signed-off-by: Kawika Avilla <avillk@amazon.com>
Co-authored-by: Kawika Avilla <avillk@amazon.com>
(cherry picked from commit e36352b)
kavilla added a commit that referenced this pull request Mar 19, 2024
This reverts commit 861f8b2.

Signed-off-by: Kawika Avilla <avillk@amazon.com>
Co-authored-by: Kawika Avilla <avillk@amazon.com>
(cherry picked from commit e36352b)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants