[Multiple Datasource Test]add more test for icon and aggregated view

[yujin-emma]

Description

add more test for icon and aggregated view

Issues Resolved

#6724
#6723

Screenshot

Testing the changes

  
 PASS  src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.test.tsx
  DataSourceAggregatedView: read all view (displayAllCompatibleDataSources is set to true)
    ✓ should render normally with local cluster configured, default datasource removed or added, and if activeDataSourceIds is present or filtered out (37 ms)
    ✓ should render normally with local cluster configured, default datasource removed or added, and if activeDataSourceIds is present or filtered out (13 ms)
    ✓ should render normally with local cluster configured, default datasource removed or added, and if activeDataSourceIds is present or filtered out (12 ms)
    ✓ should render normally with local cluster configured, default datasource removed or added, and if activeDataSourceIds is present or filtered out (16 ms)
    ✓ should render normally with local cluster configured, default datasource removed or added, and if activeDataSourceIds is present or filtered out (11 ms)
    ✓ should render normally with local cluster configured, default datasource removed or added, and if activeDataSourceIds is present or filtered out (10 ms)
    ✓ should render normally with local cluster configured, default datasource removed or added, and if activeDataSourceIds is present or filtered out (9 ms)
    ✓ should render normally with local cluster configured, default datasource removed or added, and if activeDataSourceIds is present or filtered out (8 ms)
    ✓ should render normally with local cluster configured, default datasource removed or added, and if activeDataSourceIds is present or filtered out (8 ms)
    ✓ should render normally with local cluster configured, default datasource removed or added, and if activeDataSourceIds is present or filtered out (10 ms)
  DataSourceAggregatedView: read active view (displayAllCompatibleDataSources is set to false)
    ✓ should render normally with local cluster and active selections configured (6 ms)
    ✓ should render normally with local cluster and active selections configured (7 ms)
    ✓ should render normally with local cluster and active selections configured (6 ms)
    ✓ should render normally with local cluster and active selections configured (6 ms)
    ✓ should render normally with local cluster and active selections configured (5 ms)
    ✓ should render normally with local cluster and active selections configured (6 ms)
    ✓ should render normally with local cluster and active selections configured (5 ms)
    ✓ should render normally with local cluster and active selections configured (5 ms)
  DataSourceAggregatedView empty state test with local cluster hiding
    ✓ should render warning when no data sources added (4 ms)
    ✓ should render warning when no data sources added (2 ms)
    ✓ should render warning when no data sources added (4 ms)
    ✓ should render warning when no data sources added (2 ms)
  DataSourceAggregatedView empty state test due to filter out with local cluster hiding
    ✓ should render warning when no data sources added (2 ms)
    ✓ should render warning when no data sources added (2 ms)
  DataSourceAggregatedView error state test no matter hide local cluster or not
    ✓ should render error state when catch error (2 ms)
    ✓ should render error state when catch error (2 ms)
    ✓ should render error state when catch error (1 ms)
    ✓ should render error state when catch error (1 ms)


 PASS  src/plugins/data_source_management/public/components/custom_database_icon/empty_icon.test.tsx
  Test on empty icon
    ✓ should render the component normally (7 ms)

 PASS  src/plugins/data_source_management/public/components/custom_database_icon/error_icon.test.tsx
  Test on empty icon
    ✓ should render the component normally (7 ms)

Changelog

• fix: Add more test for icon and aggregated view

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (c09285c) to head (d457fa1).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6729   +/-   ##
=======================================
  Coverage   67.69%   67.69%           
=======================================
  Files        3417     3417           
  Lines       66941    66941           
  Branches    10892    10892           
=======================================
  Hits        45318    45318           
- Misses      18974    18976    +2     
+ Partials     2649     2647    -2     

Flag	Coverage Δ
Linux_1	33.16% <ø> (ø)
Linux_2	55.59% <ø> (ø)
Linux_3	45.26% <ø> (+0.04%)	⬆️
Linux_4	34.82% <ø> (ø)
Windows_1	?
Windows_2	55.55% <ø> (ø)
Windows_3	?
Windows_4	34.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BionIT]

can we verify the toast message?

[yujin-emma]

sure, updated with

expect(toasts.add).toHaveBeenCalledTimes(1);
      expect(toasts.add.mock.calls[0][0]).toEqual({
        "color": "warning",
        "text": expect.any(Function),
        "title": "No data sources connected yet. Connect your data sources to get started."
      });
      expect(component.state('showEmptyState')).toBe(true);

[BionIT]

can we verify the empty component is mounted?

[yujin-emma]

sure, updated with:

      expect(component.find("NoDataSource").exists()).toBe(true);

[BionIT]

looks like we return empty array no matter what, and are we testing the filter at all?

[yujin-emma]

use this to define the return as empty object:

 mockResponseForSavedObjectsCalls(client, 'find', {});

Only test the empty response, added the filter test in the new push

[BionIT]

how did we simulate the error state?

[yujin-emma]

use this mock function can mock the error state:

    mockErrorResponseForSavedObjectsCalls(client, 'find');

[BionIT]

in this case, do we still need to initialize client object here?

[ZilongX]

Looks like we're missing a DCO sign off