Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Fix: Show a error toast when workspace read only user delete saved objects #6756

Merged
merged 13 commits into from
May 14, 2024

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented May 9, 2024

Description

A circle keeps rendering on the saved objects management page when workspace read only user delete a saved objects. The expected scenario is to show a error toast on this page, and users can continue with other operations.

Issues Resolved

Screenshot

Before fix:

before.fix.mov

After fix:

after.delete.mp4

Testing the changes

  • Use the branch to bootstrap and enable workspace feature flag, savedObjects permission feature flag and security plugin
  • Create a workspace named 'source-workspace' and create some saved objects in the current workspace
  • Create a internal user named 'workspace-read-only-user' in security and assign a read user to workspace-read-only-user in source workspace - setting - user&permission
image
  • Log in as workspace-read-only-user, select source-workspace, and enter the saved objects management page
  • Delete a saved object

Changelog

  • fix: Show error toast when fail to delete saved objects

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…jects

Signed-off-by: yubonluo <yubonluo@amazon.com>
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.55%. Comparing base (d585755) to head (4119bd8).

Files Patch % Lines
...ment_section/objects_table/saved_objects_table.tsx 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6756   +/-   ##
=======================================
  Coverage   67.55%   67.55%           
=======================================
  Files        3428     3428           
  Lines       67337    67340    +3     
  Branches    10994    10994           
=======================================
+ Hits        45487    45492    +5     
+ Misses      19179    19178    -1     
+ Partials     2671     2670    -1     
Flag Coverage Δ
Linux_1 33.04% <ø> (ø)
Linux_2 55.13% <ø> (ø)
Linux_3 45.15% <ø> (ø)
Linux_4 34.73% <92.85%> (+0.01%) ⬆️
Windows_1 33.06% <ø> (ø)
Windows_2 55.10% <ø> (ø)
Windows_3 45.17% <ø> (ø)
Windows_4 34.73% <92.85%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl previously approved these changes May 11, 2024
yubonluo added 2 commits May 13, 2024 11:48
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
@SuZhou-Joe SuZhou-Joe merged commit c448c52 into opensearch-project:main May 14, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 14, 2024
…ete saved objects (#6756)

* fix: show a error toast when workspace read only user delete saved objects

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #6756 created/updated

* Changeset file for PR #6756 created/updated

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Display the delete modal after failing to delete.

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Add some unit tests

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Add some state assertions

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit c448c52)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yujin-emma pushed a commit to yujin-emma/OpenSearch-Dashboards that referenced this pull request May 16, 2024
…ete saved objects (opensearch-project#6756)

* fix: show a error toast when workspace read only user delete saved objects

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR opensearch-project#6756 created/updated

* Changeset file for PR opensearch-project#6756 created/updated

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Display the delete modal after failing to delete.

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Add some unit tests

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Add some state assertions

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
BionIT added a commit that referenced this pull request May 17, 2024
)

* adjust the aggregated view padding

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* WIP

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx

Co-authored-by: Xinrui Bai-amazon <139305463+xinruiba@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6715 created/updated

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update CHANGELOG.md

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [saved objects] enable deletion of saved objects by type if configured (#6443)

* [saved objects] enable deletion of saved objects by type if configured

Adds the following settings:
```
migrations.delete.enabled
migrations.delete.types
```

`unknown` types already exist but the purpose of this type is for plugins
that are disabled. OpenSearch Dashboards gets confused when a plugin is not
defining a saved object type but the saved object exists. This can occur
when migrating from a non-OSD version and there exists non-compatiable
saved objects.

If OSD is failing to migrate an index because of a document, I can now
configure OSD to delete types of saved objects that I specified because
I know that these types should not be carried over.

resolves: #1040

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* address comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Changeset file for PR #6443 created/updated

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [tests] fix tests related to #6443 (#6722)

* [tests] fix tests related to #6443

PR: 6443 merged in previous PR that had an immediate follow up PR
to that PR. But the followup pr was not merged into 6443.

The snapshots got updated to ensure the CI passed for 6443. But
once merged into main, failures were observed.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Changeset file for PR #6722 created/updated

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* feat: add config for topRightNavigation (#6712)

* feat: add config for topRightNavigation

Signed-off-by: tygao <tygao@amazon.com>

* doc: update changelog

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR #6712 created/updated

* test: update context test

Signed-off-by: tygao <tygao@amazon.com>

* doc: update changelog

Signed-off-by: tygao <tygao@amazon.com>

* update changeset

Signed-off-by: tygao <tygao@amazon.com>

* update joi default value

Signed-off-by: tygao <tygao@amazon.com>

* add experimental annotation and add futureNavigation configuration

Signed-off-by: tygao <tygao@amazon.com>

* add experimental annotation and add futureNavigation configuration

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* move the css to the data source aggregated view

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test]add more test for icon and aggregated view (#6729)

* add more test for icon and aggregated view

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6729 created/updated

* Update CHANGELOG.md

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* update css file space and use the oui color guideline number to replace the color name in css file

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [OSD Availability] Prevent OSD process crashes when disk is full (#6733)

* prevent crash when disk full

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

* change verbose to false

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

* add changeset file

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

* update changeset contexts

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

* change feature flag name

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

---------

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [MDS] Modify toast + popover warning to include incompatible datasources (#6678)

* Fix merge conflict

Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>

* Refactor to incompatibleDataSourcesExist

Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>

* Changeset file for PR #6678 created/updated

* Move required args to the top

Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>

---------

Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test] Add test for edit data source form (#6742)

* add test for edit data source form

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6742 created/updated

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [MQL] support enhancing language selector (#6613)

Enable with `data.enhancements.enabled: true`

Allows for enhancing the data plugin UI service and search service.

#### Remaining work
* Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language
  * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range.
* Add tests
* Disable for plugins that do not support the functionality
  * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices).
  * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id.
  * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory.

### Issues Resolved

closes #6639 
closes #6311

partially resolves:
#5504

* add error data frame

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

move language to left, some styling and disable per app name

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Make Field Name Search Filter Case Insensitive (#6759)

* Make Field Name Filter Case Insensitive

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Changeset file for PR #6759 created/updated

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (#6752)

* add test for data_source_error_menu, data_source_item, data_source_multi_selectable

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6752 created/updated

* add content verify in test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [2.14][chore] update release notes (#6705)

Updates releases notes. Partially populated with: yarn release_note:generate

And gathered the rest. Cleaned up changelog.

related to: #6254

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* add http://www.site.com to lycheeignore (#6771)

* add http://www.site.com to lycheeignore

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6771 created/updated

* Update .lycheeignore

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (#6756)

* fix: show a error toast when workspace read only user delete saved objects

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #6756 created/updated

* Changeset file for PR #6756 created/updated

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Display the delete modal after failing to delete.

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Add some unit tests

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Add some state assertions

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Updating security reachout email (#6778)

Signed-off-by: varun-lodaya <varunml@amazon.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* add @zhyuanqi as a maintainer (#6788)

* add @zhyuanqi as a maintainer

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [OE] Adds dev doc script to precommit hook (#6585)

* Adds doc generation to pre commit hook

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Add check hook to pre commit

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Changeset file for PR #6585 created/updated

* Update error message

Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>

* Improve error message

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>

* fixes lint issue

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Move @BSFishy to emeritus maintainer (#6790)

* Move @BSFishy to emeritus maintainer

Signed-off-by: Lu Yu <nluyu@amazon.com>

* Changeset file for PR #6790 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* add @mengweieric as maintainer (#6798)

* add @mengweieric as maintainer

Signed-off-by: Lu Yu <nluyu@amazon.com>

* Changeset file for PR #6798 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Add OpenAPI specification for get and create saved object APIs  (#6799)

* add openapi doc

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add readme

Signed-off-by: Lu Yu <nluyu@amazon.com>

* Changeset file for PR #6799 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test]Add test for toast button and validation form (#6755)

* add test for toast button and validation form

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6755 created/updated

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx

Co-authored-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update manage_data_source_button.test.tsx

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test] Add test for edit data source form (#6742)

* add test for edit data source form

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6742 created/updated

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [MQL] support enhancing language selector (#6613)

Enable with `data.enhancements.enabled: true`

Allows for enhancing the data plugin UI service and search service.

#### Remaining work
* Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language
  * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range.
* Add tests
* Disable for plugins that do not support the functionality
  * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices).
  * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id.
  * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory.

### Issues Resolved

closes #6639 
closes #6311

partially resolves:
#5504

* add error data frame

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

move language to left, some styling and disable per app name

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Make Field Name Search Filter Case Insensitive (#6759)

* Make Field Name Filter Case Insensitive

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Changeset file for PR #6759 created/updated

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* address naming for manage data source button test id

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: varun-lodaya <varunml@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Co-authored-by: Xinrui Bai-amazon <139305463+xinruiba@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: tygao <tygao@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Tao Liu <33105471+Flyingliuhub@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Co-authored-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Co-authored-by: yuboluo <yubonluo@amazon.com>
Co-authored-by: Varun Lodaya <varunml@amazon.com>
Co-authored-by: Lu Yu <nluyu@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request May 20, 2024
…ete saved objects (#6756) (#6783)

* fix: show a error toast when workspace read only user delete saved objects



* Changeset file for PR #6756 created/updated

* Changeset file for PR #6756 created/updated

* optimize the code



* Display the delete modal after failing to delete.



* Add some unit tests



* Add some state assertions



---------



(cherry picked from commit c448c52)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 3, 2024
)

* adjust the aggregated view padding

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* WIP

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx

Co-authored-by: Xinrui Bai-amazon <139305463+xinruiba@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6715 created/updated

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update CHANGELOG.md

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [saved objects] enable deletion of saved objects by type if configured (#6443)

* [saved objects] enable deletion of saved objects by type if configured

Adds the following settings:
```
migrations.delete.enabled
migrations.delete.types
```

`unknown` types already exist but the purpose of this type is for plugins
that are disabled. OpenSearch Dashboards gets confused when a plugin is not
defining a saved object type but the saved object exists. This can occur
when migrating from a non-OSD version and there exists non-compatiable
saved objects.

If OSD is failing to migrate an index because of a document, I can now
configure OSD to delete types of saved objects that I specified because
I know that these types should not be carried over.

resolves: #1040

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* address comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Changeset file for PR #6443 created/updated

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [tests] fix tests related to #6443 (#6722)

* [tests] fix tests related to #6443

PR: 6443 merged in previous PR that had an immediate follow up PR
to that PR. But the followup pr was not merged into 6443.

The snapshots got updated to ensure the CI passed for 6443. But
once merged into main, failures were observed.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Changeset file for PR #6722 created/updated

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* feat: add config for topRightNavigation (#6712)

* feat: add config for topRightNavigation

Signed-off-by: tygao <tygao@amazon.com>

* doc: update changelog

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR #6712 created/updated

* test: update context test

Signed-off-by: tygao <tygao@amazon.com>

* doc: update changelog

Signed-off-by: tygao <tygao@amazon.com>

* update changeset

Signed-off-by: tygao <tygao@amazon.com>

* update joi default value

Signed-off-by: tygao <tygao@amazon.com>

* add experimental annotation and add futureNavigation configuration

Signed-off-by: tygao <tygao@amazon.com>

* add experimental annotation and add futureNavigation configuration

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* move the css to the data source aggregated view

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test]add more test for icon and aggregated view (#6729)

* add more test for icon and aggregated view

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6729 created/updated

* Update CHANGELOG.md

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* update css file space and use the oui color guideline number to replace the color name in css file

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [OSD Availability] Prevent OSD process crashes when disk is full (#6733)

* prevent crash when disk full

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

* change verbose to false

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

* add changeset file

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

* update changeset contexts

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

* change feature flag name

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

---------

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [MDS] Modify toast + popover warning to include incompatible datasources (#6678)

* Fix merge conflict

Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>

* Refactor to incompatibleDataSourcesExist

Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>

* Changeset file for PR #6678 created/updated

* Move required args to the top

Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>

---------

Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test] Add test for edit data source form (#6742)

* add test for edit data source form

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6742 created/updated

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [MQL] support enhancing language selector (#6613)

Enable with `data.enhancements.enabled: true`

Allows for enhancing the data plugin UI service and search service.

#### Remaining work
* Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language
  * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range.
* Add tests
* Disable for plugins that do not support the functionality
  * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices).
  * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id.
  * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory.

### Issues Resolved

closes #6639
closes #6311

partially resolves:
#5504

* add error data frame

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

move language to left, some styling and disable per app name

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Make Field Name Search Filter Case Insensitive (#6759)

* Make Field Name Filter Case Insensitive

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Changeset file for PR #6759 created/updated

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (#6752)

* add test for data_source_error_menu, data_source_item, data_source_multi_selectable

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6752 created/updated

* add content verify in test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [2.14][chore] update release notes (#6705)

Updates releases notes. Partially populated with: yarn release_note:generate

And gathered the rest. Cleaned up changelog.

related to: #6254

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* add http://www.site.com to lycheeignore (#6771)

* add http://www.site.com to lycheeignore

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6771 created/updated

* Update .lycheeignore

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (#6756)

* fix: show a error toast when workspace read only user delete saved objects

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #6756 created/updated

* Changeset file for PR #6756 created/updated

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Display the delete modal after failing to delete.

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Add some unit tests

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Add some state assertions

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Updating security reachout email (#6778)

Signed-off-by: varun-lodaya <varunml@amazon.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* add @zhyuanqi as a maintainer (#6788)

* add @zhyuanqi as a maintainer

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [OE] Adds dev doc script to precommit hook (#6585)

* Adds doc generation to pre commit hook

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Add check hook to pre commit

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Changeset file for PR #6585 created/updated

* Update error message

Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>

* Improve error message

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>

* fixes lint issue

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Move @BSFishy to emeritus maintainer (#6790)

* Move @BSFishy to emeritus maintainer

Signed-off-by: Lu Yu <nluyu@amazon.com>

* Changeset file for PR #6790 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* add @mengweieric as maintainer (#6798)

* add @mengweieric as maintainer

Signed-off-by: Lu Yu <nluyu@amazon.com>

* Changeset file for PR #6798 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Add OpenAPI specification for get and create saved object APIs  (#6799)

* add openapi doc

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add readme

Signed-off-by: Lu Yu <nluyu@amazon.com>

* Changeset file for PR #6799 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test]Add test for toast button and validation form (#6755)

* add test for toast button and validation form

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6755 created/updated

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx

Co-authored-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update manage_data_source_button.test.tsx

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test] Add test for edit data source form (#6742)

* add test for edit data source form

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6742 created/updated

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [MQL] support enhancing language selector (#6613)

Enable with `data.enhancements.enabled: true`

Allows for enhancing the data plugin UI service and search service.

#### Remaining work
* Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language
  * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range.
* Add tests
* Disable for plugins that do not support the functionality
  * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices).
  * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id.
  * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory.

### Issues Resolved

closes #6639
closes #6311

partially resolves:
#5504

* add error data frame

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

move language to left, some styling and disable per app name

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Make Field Name Search Filter Case Insensitive (#6759)

* Make Field Name Filter Case Insensitive

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Changeset file for PR #6759 created/updated

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* address naming for manage data source button test id

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: varun-lodaya <varunml@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Co-authored-by: Xinrui Bai-amazon <139305463+xinruiba@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: tygao <tygao@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Tao Liu <33105471+Flyingliuhub@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Co-authored-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Co-authored-by: yuboluo <yubonluo@amazon.com>
Co-authored-by: Varun Lodaya <varunml@amazon.com>
Co-authored-by: Lu Yu <nluyu@amazon.com>
(cherry picked from commit 9ef7404)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhyuanqi pushed a commit that referenced this pull request Jun 3, 2024
) (#6896)

* adjust the aggregated view padding



* WIP



* Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx





* Changeset file for PR #6715 created/updated



* Update CHANGELOG.md



* [saved objects] enable deletion of saved objects by type if configured (#6443)

* [saved objects] enable deletion of saved objects by type if configured

Adds the following settings:
```
migrations.delete.enabled
migrations.delete.types
```

`unknown` types already exist but the purpose of this type is for plugins
that are disabled. OpenSearch Dashboards gets confused when a plugin is not
defining a saved object type but the saved object exists. This can occur
when migrating from a non-OSD version and there exists non-compatiable
saved objects.

If OSD is failing to migrate an index because of a document, I can now
configure OSD to delete types of saved objects that I specified because
I know that these types should not be carried over.

resolves: #1040



* address comments



* Changeset file for PR #6443 created/updated

---------





* [tests] fix tests related to #6443 (#6722)

* [tests] fix tests related to #6443

PR: 6443 merged in previous PR that had an immediate follow up PR
to that PR. But the followup pr was not merged into 6443.

The snapshots got updated to ensure the CI passed for 6443. But
once merged into main, failures were observed.



* Changeset file for PR #6722 created/updated

---------





* feat: add config for topRightNavigation (#6712)

* feat: add config for topRightNavigation



* doc: update changelog



* Changeset file for PR #6712 created/updated

* test: update context test



* doc: update changelog



* update changeset



* update joi default value



* add experimental annotation and add futureNavigation configuration



* add experimental annotation and add futureNavigation configuration



---------






* move the css to the data source aggregated view



* [Multiple Datasource Test]add more test for icon and aggregated view (#6729)

* add more test for icon and aggregated view



* Changeset file for PR #6729 created/updated

* Update CHANGELOG.md

---------





* update css file space and use the oui color guideline number to replace the color name in css file



* [OSD Availability] Prevent OSD process crashes when disk is full (#6733)

* prevent crash when disk full



* change verbose to false



* add changeset file



* update changeset contexts



* change feature flag name



---------





* [MDS] Modify toast + popover warning to include incompatible datasources (#6678)

* Fix merge conflict



* Refactor to incompatibleDataSourcesExist



* Changeset file for PR #6678 created/updated

* Move required args to the top



---------





* [Multiple Datasource Test] Add test for edit data source form (#6742)

* add test for edit data source form



* Changeset file for PR #6742 created/updated

---------





* [MQL] support enhancing language selector (#6613)

Enable with `data.enhancements.enabled: true`

Allows for enhancing the data plugin UI service and search service.

#### Remaining work
* Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language
  * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range.
* Add tests
* Disable for plugins that do not support the functionality
  * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices).
  * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id.
  * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory.

### Issues Resolved

closes #6639
closes #6311

partially resolves:
#5504

* add error data frame



move language to left, some styling and disable per app name



---------







* Make Field Name Search Filter Case Insensitive (#6759)

* Make Field Name Filter Case Insensitive



* Changeset file for PR #6759 created/updated

---------





* [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (#6752)

* add test for data_source_error_menu, data_source_item, data_source_multi_selectable



* Changeset file for PR #6752 created/updated

* add content verify in test



---------





* [2.14][chore] update release notes (#6705)

Updates releases notes. Partially populated with: yarn release_note:generate

And gathered the rest. Cleaned up changelog.

related to: #6254




* add http://www.site.com to lycheeignore (#6771)

* add http://www.site.com to lycheeignore



* Changeset file for PR #6771 created/updated

* Update .lycheeignore




---------







* [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (#6756)

* fix: show a error toast when workspace read only user delete saved objects



* Changeset file for PR #6756 created/updated

* Changeset file for PR #6756 created/updated

* optimize the code



* Display the delete modal after failing to delete.



* Add some unit tests



* Add some state assertions



---------





* Updating security reachout email (#6778)




* add @zhyuanqi as a maintainer (#6788)

* add @zhyuanqi as a maintainer

---------





* [OE] Adds dev doc script to precommit hook (#6585)

* Adds doc generation to pre commit hook



* Add check hook to pre commit



* Changeset file for PR #6585 created/updated

* Update error message



* Improve error message




* fixes lint issue



---------







* Move @BSFishy to emeritus maintainer (#6790)

* Move @BSFishy to emeritus maintainer



* Changeset file for PR #6790 created/updated

---------





* add @mengweieric as maintainer (#6798)

* add @mengweieric as maintainer



* Changeset file for PR #6798 created/updated

---------





* Add OpenAPI specification for get and create saved object APIs  (#6799)

* add openapi doc



* add readme



* Changeset file for PR #6799 created/updated

---------





* [Multiple Datasource Test]Add test for toast button and validation form (#6755)

* add test for toast button and validation form



* Changeset file for PR #6755 created/updated



* Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx





* Update manage_data_source_button.test.tsx



* [Multiple Datasource Test] Add test for edit data source form (#6742)

* add test for edit data source form



* Changeset file for PR #6742 created/updated

---------





* [MQL] support enhancing language selector (#6613)

Enable with `data.enhancements.enabled: true`

Allows for enhancing the data plugin UI service and search service.

#### Remaining work
* Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language
  * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range.
* Add tests
* Disable for plugins that do not support the functionality
  * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices).
  * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id.
  * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory.

### Issues Resolved

closes #6639
closes #6311

partially resolves:
#5504

* add error data frame



move language to left, some styling and disable per app name



---------







* Make Field Name Search Filter Case Insensitive (#6759)

* Make Field Name Filter Case Insensitive



* Changeset file for PR #6759 created/updated

---------





* address naming for manage data source button test id



---------













---------




























(cherry picked from commit 9ef7404)

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: varun-lodaya <varunml@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Xinrui Bai-amazon <139305463+xinruiba@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: tygao <tygao@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Tao Liu <33105471+Flyingliuhub@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Co-authored-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Co-authored-by: yuboluo <yubonluo@amazon.com>
Co-authored-by: Varun Lodaya <varunml@amazon.com>
Co-authored-by: Lu Yu <nluyu@amazon.com>
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jun 3, 2024
…ete saved objects (opensearch-project#6756)

* fix: show a error toast when workspace read only user delete saved objects

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR opensearch-project#6756 created/updated

* Changeset file for PR opensearch-project#6756 created/updated

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Display the delete modal after failing to delete.

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Add some unit tests

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Add some state assertions

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27 added a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jun 3, 2024
…ensearch-project#6715)

* adjust the aggregated view padding

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* WIP

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx

Co-authored-by: Xinrui Bai-amazon <139305463+xinruiba@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR opensearch-project#6715 created/updated

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update CHANGELOG.md

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [saved objects] enable deletion of saved objects by type if configured (opensearch-project#6443)

* [saved objects] enable deletion of saved objects by type if configured

Adds the following settings:
```
migrations.delete.enabled
migrations.delete.types
```

`unknown` types already exist but the purpose of this type is for plugins
that are disabled. OpenSearch Dashboards gets confused when a plugin is not
defining a saved object type but the saved object exists. This can occur
when migrating from a non-OSD version and there exists non-compatiable
saved objects.

If OSD is failing to migrate an index because of a document, I can now
configure OSD to delete types of saved objects that I specified because
I know that these types should not be carried over.

resolves: opensearch-project#1040

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* address comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Changeset file for PR opensearch-project#6443 created/updated

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [tests] fix tests related to opensearch-project#6443 (opensearch-project#6722)

* [tests] fix tests related to opensearch-project#6443

PR: 6443 merged in previous PR that had an immediate follow up PR
to that PR. But the followup pr was not merged into 6443.

The snapshots got updated to ensure the CI passed for 6443. But
once merged into main, failures were observed.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Changeset file for PR opensearch-project#6722 created/updated

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* feat: add config for topRightNavigation (opensearch-project#6712)

* feat: add config for topRightNavigation

Signed-off-by: tygao <tygao@amazon.com>

* doc: update changelog

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR opensearch-project#6712 created/updated

* test: update context test

Signed-off-by: tygao <tygao@amazon.com>

* doc: update changelog

Signed-off-by: tygao <tygao@amazon.com>

* update changeset

Signed-off-by: tygao <tygao@amazon.com>

* update joi default value

Signed-off-by: tygao <tygao@amazon.com>

* add experimental annotation and add futureNavigation configuration

Signed-off-by: tygao <tygao@amazon.com>

* add experimental annotation and add futureNavigation configuration

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* move the css to the data source aggregated view

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test]add more test for icon and aggregated view (opensearch-project#6729)

* add more test for icon and aggregated view

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR opensearch-project#6729 created/updated

* Update CHANGELOG.md

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* update css file space and use the oui color guideline number to replace the color name in css file

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [OSD Availability] Prevent OSD process crashes when disk is full (opensearch-project#6733)

* prevent crash when disk full

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

* change verbose to false

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

* add changeset file

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

* update changeset contexts

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

* change feature flag name

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>

---------

Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [MDS] Modify toast + popover warning to include incompatible datasources (opensearch-project#6678)

* Fix merge conflict

Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>

* Refactor to incompatibleDataSourcesExist

Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>

* Changeset file for PR opensearch-project#6678 created/updated

* Move required args to the top

Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>

---------

Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test] Add test for edit data source form (opensearch-project#6742)

* add test for edit data source form

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR opensearch-project#6742 created/updated

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [MQL] support enhancing language selector (opensearch-project#6613)

Enable with `data.enhancements.enabled: true`

Allows for enhancing the data plugin UI service and search service.

#### Remaining work
* Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language
  * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range.
* Add tests
* Disable for plugins that do not support the functionality
  * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices).
  * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id.
  * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory.

### Issues Resolved

closes opensearch-project#6639 
closes opensearch-project#6311

partially resolves:
opensearch-project#5504

* add error data frame

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

move language to left, some styling and disable per app name

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Make Field Name Search Filter Case Insensitive (opensearch-project#6759)

* Make Field Name Filter Case Insensitive

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Changeset file for PR opensearch-project#6759 created/updated

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (opensearch-project#6752)

* add test for data_source_error_menu, data_source_item, data_source_multi_selectable

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR opensearch-project#6752 created/updated

* add content verify in test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [2.14][chore] update release notes (opensearch-project#6705)

Updates releases notes. Partially populated with: yarn release_note:generate

And gathered the rest. Cleaned up changelog.

related to: opensearch-project#6254

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* add http://www.site.com to lycheeignore (opensearch-project#6771)

* add http://www.site.com to lycheeignore

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR opensearch-project#6771 created/updated

* Update .lycheeignore

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (opensearch-project#6756)

* fix: show a error toast when workspace read only user delete saved objects

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR opensearch-project#6756 created/updated

* Changeset file for PR opensearch-project#6756 created/updated

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Display the delete modal after failing to delete.

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Add some unit tests

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Add some state assertions

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Updating security reachout email (opensearch-project#6778)

Signed-off-by: varun-lodaya <varunml@amazon.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* add @zhyuanqi as a maintainer (opensearch-project#6788)

* add @zhyuanqi as a maintainer

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [OE] Adds dev doc script to precommit hook (opensearch-project#6585)

* Adds doc generation to pre commit hook

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Add check hook to pre commit

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Changeset file for PR opensearch-project#6585 created/updated

* Update error message

Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>

* Improve error message

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>

* fixes lint issue

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Move @BSFishy to emeritus maintainer (opensearch-project#6790)

* Move @BSFishy to emeritus maintainer

Signed-off-by: Lu Yu <nluyu@amazon.com>

* Changeset file for PR opensearch-project#6790 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* add @mengweieric as maintainer (opensearch-project#6798)

* add @mengweieric as maintainer

Signed-off-by: Lu Yu <nluyu@amazon.com>

* Changeset file for PR opensearch-project#6798 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Add OpenAPI specification for get and create saved object APIs  (opensearch-project#6799)

* add openapi doc

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add readme

Signed-off-by: Lu Yu <nluyu@amazon.com>

* Changeset file for PR opensearch-project#6799 created/updated

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test]Add test for toast button and validation form (opensearch-project#6755)

* add test for toast button and validation form

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR opensearch-project#6755 created/updated

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx

Co-authored-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update manage_data_source_button.test.tsx

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [Multiple Datasource Test] Add test for edit data source form (opensearch-project#6742)

* add test for edit data source form

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR opensearch-project#6742 created/updated

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* [MQL] support enhancing language selector (opensearch-project#6613)

Enable with `data.enhancements.enabled: true`

Allows for enhancing the data plugin UI service and search service.

#### Remaining work
* Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language
  * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range.
* Add tests
* Disable for plugins that do not support the functionality
  * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices).
  * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id.
  * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory.

### Issues Resolved

closes opensearch-project#6639 
closes opensearch-project#6311

partially resolves:
opensearch-project#5504

* add error data frame

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

move language to left, some styling and disable per app name

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Make Field Name Search Filter Case Insensitive (opensearch-project#6759)

* Make Field Name Filter Case Insensitive

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Changeset file for PR opensearch-project#6759 created/updated

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* address naming for manage data source button test id

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: varun-lodaya <varunml@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Co-authored-by: Xinrui Bai-amazon <139305463+xinruiba@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: tygao <tygao@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Tao Liu <33105471+Flyingliuhub@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Co-authored-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Co-authored-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Co-authored-by: yuboluo <yubonluo@amazon.com>
Co-authored-by: Varun Lodaya <varunml@amazon.com>
Co-authored-by: Lu Yu <nluyu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants