Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smaller and compressed varients of buttons and form components #7304

Merged

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Jul 18, 2024

Replace instances of EuiButton that don't have an explicit sizing attribute to EuiSmallButton*.
Replace instances of Eui<form elements> that don't have density attributes to EuiCompressed<form elements>.
Bump OUI.

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.53%. Comparing base (54cdf23) to head (75f59ec).

Files Patch % Lines
...lic/ui/shard_failure_modal/shard_failure_modal.tsx 0.00% 2 Missing ⚠️
...c/core/public/notifications/toasts/error_toast.tsx 0.00% 1 Missing ⚠️
...cation/components/something_went_wrong_callout.tsx 0.00% 1 Missing ⚠️
...ry_management/saved_query_management_component.tsx 0.00% 1 Missing ⚠️
..._actions/customize_title/customize_panel_modal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7304      +/-   ##
==========================================
- Coverage   67.53%   67.53%   -0.01%     
==========================================
  Files        3504     3504              
  Lines       69407    69407              
  Branches    11324    11324              
==========================================
- Hits        46874    46872       -2     
- Misses      19773    19775       +2     
  Partials     2760     2760              
Flag Coverage Δ
Linux_1 33.15% <14.28%> (ø)
Linux_2 55.46% <0.00%> (ø)
Linux_3 43.06% <40.00%> (+0.01%) ⬆️
Linux_4 34.76% <60.00%> (ø)
Windows_1 33.17% <14.28%> (ø)
Windows_2 55.41% <0.00%> (ø)
Windows_3 43.06% <40.00%> (ø)
Windows_4 34.76% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongnansu zhongnansu added the look & feel Look and Feel Improvements label Jul 18, 2024
@AMoo-Miki AMoo-Miki force-pushed the compressed-rows-smaller-buttons-2 branch 4 times, most recently from 20b0fcb to dcebb6d Compare July 19, 2024 17:48
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
ashwin-pc
ashwin-pc previously approved these changes Jul 19, 2024
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the only changes are changing the component to use the new ones. Thanks for not mixing any other change in this at the same time.

Signed-off-by: Miki <miki@amazon.com>
@virajsanghvi
Copy link
Collaborator

Approving assuming last check passes.

@AMoo-Miki AMoo-Miki merged commit 6f28170 into opensearch-project:main Jul 19, 2024
69 of 70 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7304-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6f28170af93d842a0567c74bbabfe6ba9e5314c0
# Push it to GitHub
git push --set-upstream origin backport/backport-7304-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7304-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7304-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6f28170af93d842a0567c74bbabfe6ba9e5314c0
# Push it to GitHub
git push --set-upstream origin backport/backport-7304-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7304-to-2.x.

AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Jul 23, 2024
…pensearch-project#7304)

* Bump OUI

Signed-off-by: Miki <miki@amazon.com>

* Use EuiSmallButton

Signed-off-by: Miki <miki@amazon.com>

* Use EuiSmallButtonIcon

Signed-off-by: Miki <miki@amazon.com>

* Use EuiSmallButtonEmpty

Signed-off-by: Miki <miki@amazon.com>

* Use EuiCompressedFormRow

Signed-off-by: Miki <miki@amazon.com>

* Use EuiCompressedField*

Signed-off-by: Miki <miki@amazon.com>

* Use EuiCompressedSelect and EuiCompressedSuperSelect

Signed-off-by: Miki <miki@amazon.com>

* Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup

Signed-off-by: Miki <miki@amazon.com>

* Use EuiCompressedFilePicker

Signed-off-by: Miki <miki@amazon.com>

* Use EuiCompressedRadio and EuiCompressedRadioGroup

Signed-off-by: Miki <miki@amazon.com>

* Use EuiCompressedSwitch

Signed-off-by: Miki <miki@amazon.com>

* Use EuiCompressedEuiTextArea

Signed-off-by: Miki <miki@amazon.com>

* Use EuiCompressedComboBox

Signed-off-by: Miki <miki@amazon.com>

* Use compressed ValidatedDualRange

Signed-off-by: Miki <miki@amazon.com>

* Use EuiSmallFilterButton

Signed-off-by: Miki <miki@amazon.com>

* Undo unnecessary EuiSmallButton* uses

Signed-off-by: Miki <miki@amazon.com>

* Revisit size and density changes in workspaces

Signed-off-by: Miki <miki@amazon.com>

* Fix unit tests

Signed-off-by: Miki <miki@amazon.com>

---------

Signed-off-by: Miki <miki@amazon.com>

(cherry picked from commit 6f28170)
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki added a commit that referenced this pull request Jul 23, 2024
…7304) (#7417)

* Bump OUI



* Use EuiSmallButton



* Use EuiSmallButtonIcon



* Use EuiSmallButtonEmpty



* Use EuiCompressedFormRow



* Use EuiCompressedField*



* Use EuiCompressedSelect and EuiCompressedSuperSelect



* Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup



* Use EuiCompressedFilePicker



* Use EuiCompressedRadio and EuiCompressedRadioGroup



* Use EuiCompressedSwitch



* Use EuiCompressedEuiTextArea



* Use EuiCompressedComboBox



* Use compressed ValidatedDualRange



* Use EuiSmallFilterButton



* Undo unnecessary EuiSmallButton* uses



* Revisit size and density changes in workspaces



* Fix unit tests



---------



(cherry picked from commit 6f28170)

Signed-off-by: Miki <miki@amazon.com>
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
…pensearch-project#7304) (opensearch-project#7417)

* Bump OUI



* Use EuiSmallButton



* Use EuiSmallButtonIcon



* Use EuiSmallButtonEmpty



* Use EuiCompressedFormRow



* Use EuiCompressedField*



* Use EuiCompressedSelect and EuiCompressedSuperSelect



* Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup



* Use EuiCompressedFilePicker



* Use EuiCompressedRadio and EuiCompressedRadioGroup



* Use EuiCompressedSwitch



* Use EuiCompressedEuiTextArea



* Use EuiCompressedComboBox



* Use compressed ValidatedDualRange



* Use EuiSmallFilterButton



* Undo unnecessary EuiSmallButton* uses



* Revisit size and density changes in workspaces



* Fix unit tests



---------



(cherry picked from commit 6f28170)

Signed-off-by: Miki <miki@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x distinguished-contributor look & feel Look and Feel Improvements Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants