Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual] [Backport 2.16] [Look&Feel] Replace browser tooltip usage with OUI tooltip #7465

Conversation

danieldong51
Copy link
Contributor

Description

Manual backport #7231 to 2.16. Conflicts include:

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@danieldong51
Copy link
Contributor Author

relies on the backport to 2.16 of #7304

Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com>
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.79%. Comparing base (812a9e9) to head (70adc49).

Files Patch % Lines
...ation/components/sidebar/discover_field_bucket.tsx 50.00% 2 Missing ⚠️
src/core/public/chrome/ui/header/header.tsx 0.00% 1 Missing ⚠️
.../application/components/sidebar/discover_field.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.16    #7465      +/-   ##
==========================================
+ Coverage   67.76%   67.79%   +0.03%     
==========================================
  Files        3595     3595              
  Lines       72473    72477       +4     
  Branches    11876    11876              
==========================================
+ Hits        49109    49139      +30     
+ Misses      20371    20335      -36     
- Partials     2993     3003      +10     
Flag Coverage Δ
Linux_1 33.44% <20.00%> (+<0.01%) ⬆️
Linux_2 55.70% <75.00%> (+0.04%) ⬆️
Linux_3 ?
Linux_4 34.19% <0.00%> (ø)
Windows_1 33.46% <20.00%> (+<0.01%) ⬆️
Windows_2 55.65% <75.00%> (+0.04%) ⬆️
Windows_3 44.50% <41.66%> (+0.04%) ⬆️
Windows_4 34.19% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh ananzh deleted the branch opensearch-project:2.16 July 24, 2024 23:56
@ananzh ananzh closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants