feat: provide new embeddable option to hide embeddable panel action button #7503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utton Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi and
sejli
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7503 +/- ##
==========================================
- Coverage 63.98% 63.66% -0.32%
==========================================
Files 3598 3632 +34
Lines 78322 80070 +1748
Branches 12352 12688 +336
==========================================
+ Hits 50111 50978 +867
- Misses 25189 25986 +797
- Partials 3022 3106 +84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
previously approved these changes
Aug 7, 2024
AMoo-Miki
reviewed
Aug 7, 2024
AMoo-Miki
reviewed
Aug 7, 2024
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
|
@AMoo-Miki Thanks for the feedback, PR updated, could take a another look please? |
SuZhou-Joe
approved these changes
Aug 8, 2024
AMoo-Miki
approved these changes
Aug 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2024
…utton (#7503) * feat: provide new embeddable option to hide embeddable panel action button Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Changeset file for PR #7503 created/updated * cleanup unnecessary getInput() calls Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 1bf63e3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Aug 12, 2024
…utton (#7503) (#7676) * feat: provide new embeddable option to hide embeddable panel action button * Changeset file for PR #7503 created/updated * cleanup unnecessary getInput() calls --------- (cherry picked from commit 1bf63e3) Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the existing options
hidePanelTitleswhich hide embeddable panel titles, this PR introduced a new optionhidePanelActionsto hide the embeddable action button, this is useful for embeddable panels that don't have action, right now, action button always shows even when there was no action:With this PR, it's possible to hide the action button by specifying
{hidePanelActions: true}in embeddable inputDescription
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration