Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] feat: provide new embeddable option to hide embeddable panel action button #7676

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1bf63e3 from #7503.

…utton (#7503)

* feat: provide new embeddable option to hide embeddable panel action button

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* Changeset file for PR #7503 created/updated

* cleanup unnecessary getInput() calls

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 1bf63e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.77%. Comparing base (64edc4f) to head (b367161).

Files Patch % Lines
...s/embeddable/public/lib/panel/embeddable_panel.tsx 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7676   +/-   ##
=======================================
  Coverage   63.77%   63.77%           
=======================================
  Files        3633     3633           
  Lines       80148    80157    +9     
  Branches    12685    12689    +4     
=======================================
+ Hits        51115    51124    +9     
  Misses      25932    25932           
  Partials     3101     3101           
Flag Coverage Δ
Linux_1 30.64% <0.00%> (-0.01%) ⬇️
Linux_2 55.70% <ø> (ø)
Linux_3 40.64% <83.33%> (+<0.01%) ⬆️
Linux_4 31.48% <91.66%> (+0.01%) ⬆️
Windows_1 30.65% <0.00%> (-0.01%) ⬇️
Windows_2 55.65% <ø> (ø)
Windows_3 40.64% <83.33%> (+<0.01%) ⬆️
Windows_4 31.48% <91.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 49f9326 into 2.x Aug 12, 2024
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset seasoned-contributor v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants