[Workspace] Update workspace list page table #7640

Qxisylolo · 2024-08-07T09:58:41Z

Description

In this pr, I refractor the workList table by adding 2 new fields, integrating 3 actions[delete, copyId, edit] , utilizing the Use Case selector, creating an empty state and enabling multiple deletion.

New update:
save a new field Use Case which is extracted from field features.
Add multiple deletion

Screenshot

When hovering over the description, you will see the tool tip.

Perform filtering by Use case

Integrating 3 actions

Performing search

Empty state

Enable multiple deletion

Changelog

feat: [Workspace] Update workspace list page table

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

…s table Signed-off-by: Qxisylolo <qianxisy@amazon.com>

…s table, add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com>

… add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com>

src/plugins/workspace/public/components/workspace_list/index.tsx

codecov · 2024-08-07T10:23:11Z

Codecov Report

Attention: Patch coverage is 67.10526% with 25 lines in your changes missing coverage. Please review.

Project coverage is 63.76%. Comparing base (36af5e7) to head (94703a0).
Report is 15 commits behind head on main.

Files	Patch %	Lines
...rkspace/public/components/workspace_list/index.tsx	64.91%	16 Missing and 4 partials ⚠️
.../delete_workspace_modal/delete_workspace_modal.tsx	73.68%	0 Missing and 5 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7640   +/-   ##
=======================================
  Coverage   63.75%   63.76%           
=======================================
  Files        3639     3639           
  Lines       80461    80491   +30     
  Branches    12800    12804    +4     
=======================================
+ Hits        51297    51323   +26     
  Misses      26028    26028           
- Partials     3136     3140    +4

Flag	Coverage Δ
Linux_1	`29.85% <67.10%> (+<0.01%)`	⬆️
Linux_2	`55.82% <ø> (ø)`
Linux_3	`40.39% <ø> (ø)`
Linux_4	`31.30% <ø> (ø)`
Windows_1	`29.88% <67.10%> (+0.02%)`	⬆️
Windows_2	`55.77% <ø> (ø)`
Windows_3	`40.39% <ø> (ø)`
Windows_4	`31.30% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…, add tests, and refine based the comments Signed-off-by: Qxisylolo <qianxisy@amazon.com>

…, add tests, and update based the comments Signed-off-by: Qxisylolo <qianxisy@amazon.com>

…, add tests, and update based the comment-1 Signed-off-by: Qxisylolo <qianxisy@amazon.com>

src/plugins/workspace/public/components/workspace_list/index.tsx

ruanyl · 2024-08-08T10:06:43Z

src/plugins/workspace/public/components/workspace_list/index.tsx

+    return workspaceList.map(
+      (workspace): WorkspaceAttributeWithUseCaseID => ({
+        ...workspace,
+        useCase: [...(workspace.features || [])],


We can make it a string instead of array, then you don't need to call getFirstUseCaseOfFeatureConfigs many times

Suggested change

useCase: [...(workspace.features || [])],

useCase: getFirstUseCaseOfFeatureConfigs(workspace.features || []) ?? ''

Seems there is bug when it's an array, see my screenshot

Thank you for all your comments. I have updated the array to a string and addressed the other issues mentioned. Could you please help me review the changes and let me know if the bug still persists? Thank you!

src/plugins/workspace/public/components/workspace_list/index.tsx

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

src/plugins/workspace/public/components/workspace_list/index.tsx

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

src/plugins/workspace/public/components/workspace_list/index.tsx

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* the table basically works Signed-off-by: Qxisylolo <qianxisy@amazon.com> * the table basically works new Signed-off-by: Qxisylolo <qianxisy@amazon.com> * This time I achieve the functionality and apprearence of the workLists table Signed-off-by: Qxisylolo <qianxisy@amazon.com> * This time I achieve the functionality and apprearence of the workLists table, add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * This time I achieve the functionality and apprearence of the workLists table, add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Achieve the functionality and apprearence of the workLists table, and add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR #7640 created/updated * Changeset file for PR #7640 created/updated * Changeset file for PR #7640 created/updated * Achieve the functionality and apprearence of the work List table page, add tests, and refine based the comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Achieve the functionality and apprearence of the work List table page, add tests, and update based the comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Achieve the functionality and apprearence of the work List table page, add tests, and update based the comment-1 Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Achieve the functionality and apprearence of the work List table page, add tests, and update based the comment-1 Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Enable multiple deletion and correct the code based on comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Enable multiple deletion and correct the code based on comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * set the advanced date format Signed-off-by: Qxisylolo <qianxisy@amazon.com> * set advanced time format and tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e70bfad) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* the table basically works Signed-off-by: Qxisylolo <qianxisy@amazon.com> * the table basically works new Signed-off-by: Qxisylolo <qianxisy@amazon.com> * This time I achieve the functionality and apprearence of the workLists table Signed-off-by: Qxisylolo <qianxisy@amazon.com> * This time I achieve the functionality and apprearence of the workLists table, add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * This time I achieve the functionality and apprearence of the workLists table, add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Achieve the functionality and apprearence of the workLists table, and add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR opensearch-project#7640 created/updated * Changeset file for PR opensearch-project#7640 created/updated * Changeset file for PR opensearch-project#7640 created/updated * Achieve the functionality and apprearence of the work List table page, add tests, and refine based the comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Achieve the functionality and apprearence of the work List table page, add tests, and update based the comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Achieve the functionality and apprearence of the work List table page, add tests, and update based the comment-1 Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Achieve the functionality and apprearence of the work List table page, add tests, and update based the comment-1 Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Enable multiple deletion and correct the code based on comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Enable multiple deletion and correct the code based on comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * set the advanced date format Signed-off-by: Qxisylolo <qianxisy@amazon.com> * set advanced time format and tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* the table basically works Signed-off-by: Qxisylolo <qianxisy@amazon.com> * the table basically works new Signed-off-by: Qxisylolo <qianxisy@amazon.com> * This time I achieve the functionality and apprearence of the workLists table Signed-off-by: Qxisylolo <qianxisy@amazon.com> * This time I achieve the functionality and apprearence of the workLists table, add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * This time I achieve the functionality and apprearence of the workLists table, add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Achieve the functionality and apprearence of the workLists table, and add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR #7640 created/updated * Changeset file for PR #7640 created/updated * Changeset file for PR #7640 created/updated * Achieve the functionality and apprearence of the work List table page, add tests, and refine based the comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Achieve the functionality and apprearence of the work List table page, add tests, and update based the comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Achieve the functionality and apprearence of the work List table page, add tests, and update based the comment-1 Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Achieve the functionality and apprearence of the work List table page, add tests, and update based the comment-1 Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Enable multiple deletion and correct the code based on comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Enable multiple deletion and correct the code based on comments Signed-off-by: Qxisylolo <qianxisy@amazon.com> * set the advanced date format Signed-off-by: Qxisylolo <qianxisy@amazon.com> * set advanced time format and tests Signed-off-by: Qxisylolo <qianxisy@amazon.com> --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e70bfad) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* the table basically works * the table basically works new * This time I achieve the functionality and apprearence of the workLists table * This time I achieve the functionality and apprearence of the workLists table, add tests * This time I achieve the functionality and apprearence of the workLists table, add tests * Achieve the functionality and apprearence of the workLists table, and add tests * Changeset file for PR #7640 created/updated * Changeset file for PR #7640 created/updated * Changeset file for PR #7640 created/updated * Achieve the functionality and apprearence of the work List table page, add tests, and refine based the comments * Achieve the functionality and apprearence of the work List table page, add tests, and update based the comments * Achieve the functionality and apprearence of the work List table page, add tests, and update based the comment-1 * Achieve the functionality and apprearence of the work List table page, add tests, and update based the comment-1 * Enable multiple deletion and correct the code based on comments * Enable multiple deletion and correct the code based on comments * set the advanced date format * set advanced time format and tests --------- (cherry picked from commit e70bfad) Signed-off-by: Qxisylolo <qianxisy@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>

Qxisylolo added 6 commits August 5, 2024 17:54

the table basically works

41c8d00

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

the table basically works new

e76395c

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

This time I achieve the functionality and apprearence of the workList…

d601e94

…s table Signed-off-by: Qxisylolo <qianxisy@amazon.com>

This time I achieve the functionality and apprearence of the workList…

c77079f

…s table, add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com>

This time I achieve the functionality and apprearence of the workList…

c6323e8

…s table, add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com>

Achieve the functionality and apprearence of the workLists table, and…

2f03420

… add tests Signed-off-by: Qxisylolo <qianxisy@amazon.com>

github-actions bot added the repeat-contributor label Aug 7, 2024

opensearch-changeset-bot bot added 2 commits August 7, 2024 10:05

Changeset file for PR opensearch-project#7640 created/updated

d368602

Changeset file for PR opensearch-project#7640 created/updated

670b04c

raintygao reviewed Aug 7, 2024

View reviewed changes

src/plugins/workspace/public/components/workspace_list/index.tsx Outdated Show resolved Hide resolved

src/plugins/workspace/public/components/workspace_list/index.tsx Outdated Show resolved Hide resolved

Hailong-am reviewed Aug 7, 2024

View reviewed changes

src/plugins/workspace/public/components/workspace_list/index.tsx Outdated Show resolved Hide resolved

Qxisylolo added 4 commits August 8, 2024 10:49

Achieve the functionality and apprearence of the work List table page…

220a4f0

…, add tests, and refine based the comments Signed-off-by: Qxisylolo <qianxisy@amazon.com>

Achieve the functionality and apprearence of the work List table page…

3b3850d

…, add tests, and update based the comments Signed-off-by: Qxisylolo <qianxisy@amazon.com>

Achieve the functionality and apprearence of the work List table page…

9b3410f

…, add tests, and update based the comment-1 Signed-off-by: Qxisylolo <qianxisy@amazon.com>

Achieve the functionality and apprearence of the work List table page…

86b4513

…, add tests, and update based the comment-1 Signed-off-by: Qxisylolo <qianxisy@amazon.com>

ruanyl reviewed Aug 8, 2024

View reviewed changes

src/plugins/workspace/public/components/workspace_list/index.tsx Outdated Show resolved Hide resolved

ruanyl reviewed Aug 8, 2024

View reviewed changes

src/plugins/workspace/public/components/workspace_list/index.tsx Outdated Show resolved Hide resolved

Enable multiple deletion and correct the code based on comments

18ba7ca

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

raintygao reviewed Aug 9, 2024

View reviewed changes

src/plugins/workspace/public/components/workspace_list/index.tsx Outdated Show resolved Hide resolved

Enable multiple deletion and correct the code based on comments

62e451a

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

ruanyl added workspace v2.17.0 labels Aug 12, 2024

set the advanced date format

4b26196

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

wanglam reviewed Aug 14, 2024

View reviewed changes

src/plugins/workspace/public/components/workspace_list/index.tsx Outdated Show resolved Hide resolved

Qxisylolo added 2 commits August 14, 2024 13:46

set advanced time format and tests

9fc525c

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

Merge main branch

94703a0

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

ruanyl approved these changes Aug 16, 2024

View reviewed changes

SuZhou-Joe approved these changes Aug 20, 2024

View reviewed changes

SuZhou-Joe added the backport 2.x label Aug 20, 2024

SuZhou-Joe merged commit e70bfad into opensearch-project:main Aug 20, 2024
69 of 70 checks passed

opensearch-trigger-bot bot mentioned this pull request Aug 20, 2024

[Backport 2.x] [Workspace] Update workspace list page table #7761

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace] Update workspace list page table #7640

[Workspace] Update workspace list page table #7640

Qxisylolo commented Aug 7, 2024 •

edited

Loading

codecov bot commented Aug 7, 2024 •

edited

Loading

ruanyl Aug 8, 2024

ruanyl Aug 8, 2024

Qxisylolo Aug 9, 2024 •

edited

Loading

	useCase: [...(workspace.features \|\| [])],
	useCase: getFirstUseCaseOfFeatureConfigs(workspace.features \|\| []) ?? ''

[Workspace] Update workspace list page table #7640

[Workspace] Update workspace list page table #7640

Conversation

Qxisylolo commented Aug 7, 2024 • edited Loading

Description

Screenshot

Changelog

Check List

codecov bot commented Aug 7, 2024 • edited Loading

Codecov Report

ruanyl Aug 8, 2024

Choose a reason for hiding this comment

ruanyl Aug 8, 2024

Choose a reason for hiding this comment

Qxisylolo Aug 9, 2024 • edited Loading

Choose a reason for hiding this comment

Qxisylolo commented Aug 7, 2024 •

edited

Loading

codecov bot commented Aug 7, 2024 •

edited

Loading

Qxisylolo Aug 9, 2024 •

edited

Loading