Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace] Update workspace list page table #7761

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e70bfad from #7640.

Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 67.10526% with 25 lines in your changes missing coverage. Please review.

Project coverage is 63.90%. Comparing base (ccec03d) to head (cd99e0e).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...rkspace/public/components/workspace_list/index.tsx 64.91% 16 Missing and 4 partials ⚠️
.../delete_workspace_modal/delete_workspace_modal.tsx 73.68% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7761      +/-   ##
==========================================
- Coverage   63.90%   63.90%   -0.01%     
==========================================
  Files        3657     3657              
  Lines       81260    81290      +30     
  Branches    12952    12956       +4     
==========================================
+ Hits        51929    51948      +19     
- Misses      26148    26157       +9     
- Partials     3183     3185       +2     
Flag Coverage Δ
Linux_1 30.13% <67.10%> (+<0.01%) ⬆️
Linux_2 55.99% <ø> (ø)
Linux_3 40.48% <ø> (ø)
Linux_4 31.48% <ø> (ø)
Windows_1 30.14% <67.10%> (+<0.01%) ⬆️
Windows_2 55.94% <ø> (ø)
Windows_3 40.48% <ø> (ø)
Windows_4 31.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe
Copy link
Member

Close this PR as CI failed, @Qxisylolo will help to raise a PR with 2 commits id combined(the original commit and the unit test fix commit)

@SuZhou-Joe SuZhou-Joe closed this Aug 20, 2024
@SuZhou-Joe SuZhou-Joe reopened this Aug 26, 2024
* the table basically works

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* the table basically works new

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* This time I achieve the functionality and apprearence of the workLists table

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* This time I achieve the functionality and apprearence of the workLists table, add tests

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* This time I achieve the functionality and apprearence of the workLists table, add tests

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* Achieve the functionality and apprearence of the workLists table, and add tests

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* Changeset file for PR #7640 created/updated

* Changeset file for PR #7640 created/updated

* Changeset file for PR #7640 created/updated

* Achieve the functionality and apprearence of the work List table page, add tests, and refine based the comments

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* Achieve the functionality and apprearence of the work List table page, add tests, and update based the comments

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* Achieve the functionality and apprearence of the work List table page, add tests, and update based the comment-1

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* Achieve the functionality and apprearence of the work List table page, add tests, and update based the comment-1

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* Enable multiple deletion and correct the code based on comments

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* Enable multiple deletion and correct the code based on comments

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* set the advanced date format

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* set advanced time format and tests

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

---------

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit e70bfad)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-7640-to-2.x branch from 76bffcb to 361be76 Compare August 26, 2024 02:13
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@ruanyl ruanyl merged commit 61f580d into 2.x Aug 26, 2024
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset repeat-contributor v2.17.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants