Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add workspace info in index pattern and asset header and update workspace header #7859

Merged
merged 12 commits into from
Sep 3, 2024
Merged

refactor: add workspace info in index pattern and asset header and update workspace header #7859

merged 12 commits into from
Sep 3, 2024

Conversation

raintygao
Copy link
Contributor

@raintygao raintygao commented Aug 27, 2024 •
edited
Loading

Description

  1. Add workspace info in header of index patterns and assets page when in workspace
  2. Update some page header API usage from render component to button definition
  3. fine-tune the padding style for workspace settings page and assets page.

Screenshot

image
out of workspace
image
in workspace
image
out of workspace
image
in workspace

image

image

image

Testing the changes

Enable useNewHomePage and go to index pattern, assets and workspace pages.

Changelog

  • refactor: add workspace info in index pattern and asset header and update workspace header

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Aug 27, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#7859 created/updated
0dca1a8
@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (976c567) to head (1983f1a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...attern_management/public/components/breadcrumbs.ts 0.00% 0 Missing and 1 partial ⚠️
...gement_section/objects_table/components/header.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7859   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files        3685     3685           
  Lines       87143    87145    +2     
  Branches    13405    13410    +5     
=======================================
+ Hits        53169    53173    +4     
+ Misses      30755    30752    -3     
- Partials     3219     3220    +1
Flag Coverage Δ
Linux_1 29.36% <0.00%> (-0.01%) ⬇️
Linux_2 56.22% <ø> (ø)
Linux_3 37.82% <0.00%> (?)
Linux_4 29.59% <81.81%> (+<0.01%) ⬆️
Windows_1 29.38% <0.00%> (-0.01%) ⬇️
Windows_2 56.17% <ø> (ø)
Windows_3 37.82% <0.00%> (-0.01%) ⬇️
Windows_4 29.59% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raintygao raintygao marked this pull request as ready for review August 27, 2024 08:55
SuZhou-Joe
SuZhou-Joe previously approved these changes Aug 27, 2024
View reviewed changes
@raintygao
test: update snapshots for feature cards
4cdf5f9 
Signed-off-by: tygao <tygao@amazon.com>
SuZhou-Joe
SuZhou-Joe previously approved these changes Aug 29, 2024
View reviewed changes
ruanyl
ruanyl previously approved these changes Sep 2, 2024
View reviewed changes
...ugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx Outdated Show resolved Hide resolved
...ugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx Outdated
currentWorkspace
? {
defaultMessage:
'Create and manage the index patterns that help you retrieve your data from OpenSearch for {name} workspace. ',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: seems there is an extra space at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it. Updated.

...ugins/saved_objects_management/public/management_section/objects_table/components/header.tsx Outdated Show resolved Hide resolved
@raintygao @ruanyl
Update src/plugins/index_pattern_management/public/components/index_p…
28ecfb9 
…attern_table/index_pattern_table.tsx

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>
@raintygao raintygao dismissed stale reviews from ruanyl and SuZhou-Joe via 28ecfb9 September 2, 2024 03:20
raintygao and others added 2 commits September 2, 2024 11:21
@raintygao @ruanyl
Update src/plugins/saved_objects_management/public/management_section…
7e95a26 
…/objects_table/components/header.tsx

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>
@raintygao
remove extra space in sentence
397a89e 
Signed-off-by: tygao <tygao@amazon.com>
ruanyl
ruanyl previously approved these changes Sep 2, 2024
View reviewed changes
SuZhou-Joe
SuZhou-Joe previously approved these changes Sep 2, 2024
View reviewed changes
@SuZhou-Joe SuZhou-Joe self-requested a review September 2, 2024 03:48
@raintygao
lint: break line
c1286cb 
Signed-off-by: tygao <tygao@amazon.com>
@ruanyl ruanyl merged commit cbe74d8 into opensearch-project:main Sep 3, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
@github-actions @opensearch-changeset-bot
@ruanyl @SuZhou-Joe
refactor: add workspace info in index pattern and asset header and up…
58c98e3 
…date workspace header (#7859)

* update header for objects

Signed-off-by: tygao <tygao@amazon.com>

* remove render component button and add workspace info in index pattern header

Signed-off-by: tygao <tygao@amazon.com>

* style: update workspace list button based on latest mockup

Signed-off-by: tygao <tygao@amazon.com>

* fine-tune style for workspace and saved objects

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR #7859 created/updated

* test: update snapshots for feature cards

Signed-off-by: tygao <tygao@amazon.com>

* Update src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>

* Update src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>

* remove extra space in sentence

Signed-off-by: tygao <tygao@amazon.com>

* lint: break line

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit cbe74d8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 3, 2024
Merged
ruanyl added a commit that referenced this pull request Sep 4, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @ruanyl @SuZhou-Joe
refactor: add workspace info in index pattern and asset header and up…
f7a168d 
…date workspace header (#7859) (#7972)

* update header for objects



* remove render component button and add workspace info in index pattern header



* style: update workspace list button based on latest mockup



* fine-tune style for workspace and saved objects



* Changeset file for PR #7859 created/updated

* test: update snapshots for feature cards



* Update src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx




* Update src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx




* remove extra space in sentence



* lint: break line



---------






(cherry picked from commit cbe74d8)

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
@github-actions @opensearch-changeset-bot
@ruanyl @SuZhou-Joe
refactor: add workspace info in index pattern and asset header and up…
9fadf73 
…date workspace header (#7859) (#7972)

* update header for objects

* remove render component button and add workspace info in index pattern header

* style: update workspace list button based on latest mockup

* fine-tune style for workspace and saved objects

* Changeset file for PR #7859 created/updated

* test: update snapshots for feature cards

* Update src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx

* Update src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx

* remove extra space in sentence

* lint: break line

---------

(cherry picked from commit cbe74d8)

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit f7a168d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe added a commit that referenced this pull request Sep 6, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @ruanyl @SuZhou-Joe
refactor: add workspace info in index pattern and asset header and up…
263cf25 
…date workspace header (#7859) (#7972) (#8005)

* update header for objects

* remove render component button and add workspace info in index pattern header

* style: update workspace list button based on latest mockup

* fine-tune style for workspace and saved objects

* Changeset file for PR #7859 created/updated

* test: update snapshots for feature cards

* Update src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx

* Update src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx

* remove extra space in sentence

* lint: break line

---------

(cherry picked from commit cbe74d8)








(cherry picked from commit f7a168d)

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport 2.x v2.17.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raintygao @ruanyl @SuZhou-Joe