Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] refactor: add workspace info in index pattern and asset header and update workspace header #7972

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[Backport 2.x] refactor: add workspace info in index pattern and asset header and update workspace header #7972

merged 1 commit into from
Sep 4, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport cbe74d8 from #7859.

@github-actions @opensearch-changeset-bot
@ruanyl @SuZhou-Joe
refactor: add workspace info in index pattern and asset header and up…
58c98e3 
…date workspace header (#7859)

* update header for objects

Signed-off-by: tygao <tygao@amazon.com>

* remove render component button and add workspace info in index pattern header

Signed-off-by: tygao <tygao@amazon.com>

* style: update workspace list button based on latest mockup

Signed-off-by: tygao <tygao@amazon.com>

* fine-tune style for workspace and saved objects

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR #7859 created/updated

* test: update snapshots for feature cards

Signed-off-by: tygao <tygao@amazon.com>

* Update src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>

* Update src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>

* remove extra space in sentence

Signed-off-by: tygao <tygao@amazon.com>

* lint: break line

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit cbe74d8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports all-star-contributor workspace v2.17.0 labels Sep 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (bbcdcd3) to head (58c98e3).
Report is 14 commits behind head on 2.x.

Files with missing lines Patch % Lines
...attern_management/public/components/breadcrumbs.ts 0.00% 0 Missing and 1 partial ⚠️
...gement_section/objects_table/components/header.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #7972      +/-   ##
==========================================
- Coverage   61.02%   61.01%   -0.01%     
==========================================
  Files        3671     3671              
  Lines       86775    86777       +2     
  Branches    13338    13343       +5     
==========================================
- Hits        52951    52950       -1     
  Misses      30625    30625              
- Partials     3199     3202       +3
Flag Coverage Δ
Linux_1 28.89% <0.00%> (-0.01%) ⬇️
Linux_2 56.18% <ø> (ø)
Linux_3 37.95% <0.00%> (-0.01%) ⬇️
Linux_4 29.77% <81.81%> (+<0.01%) ⬆️
Windows_1 28.91% <0.00%> (-0.01%) ⬇️
Windows_2 56.13% <ø> (ø)
Windows_3 37.96% <0.00%> (-0.01%) ⬇️
Windows_4 29.77% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit f7a168d into 2.x Sep 4, 2024
68 of 70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
@github-actions @opensearch-changeset-bot
@ruanyl @SuZhou-Joe
refactor: add workspace info in index pattern and asset header and up…
9fadf73 
…date workspace header (#7859) (#7972)

* update header for objects

* remove render component button and add workspace info in index pattern header

* style: update workspace list button based on latest mockup

* fine-tune style for workspace and saved objects

* Changeset file for PR #7859 created/updated

* test: update snapshots for feature cards

* Update src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx

* Update src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx

* remove extra space in sentence

* lint: break line

---------

(cherry picked from commit cbe74d8)

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit f7a168d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 5, 2024
Merged
SuZhou-Joe added a commit that referenced this pull request Sep 6, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @ruanyl @SuZhou-Joe
refactor: add workspace info in index pattern and asset header and up…
263cf25 
…date workspace header (#7859) (#7972) (#8005)

* update header for objects

* remove render component button and add workspace info in index pattern header

* style: update workspace list button based on latest mockup

* fine-tune style for workspace and saved objects

* Changeset file for PR #7859 created/updated

* test: update snapshots for feature cards

* Update src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx

* Update src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx

* remove extra space in sentence

* lint: break line

---------

(cherry picked from commit cbe74d8)








(cherry picked from commit f7a168d)

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@sejli sejli sejli approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
all-star-contributor autocut Skip the changelog verification check on backports backport 2.17 failed changeset v2.17.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SuZhou-Joe @sejli @ruanyl @kavilla