[Backport 2.x] [Workspace]Validate features parameter in workspace create and update API #7937
Conversation
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
… API (#7884) * Add validate for features field in workspace create and update API Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #7884 created/updated * Changeset file for PR #7884 created/updated * Move router outside align with other plugins Signed-off-by: Lin Wang <wonglam@amazon.com> * Add ut and fix integration tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Import use case id from default nav groups Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix workspace routes UT Signed-off-by: Lin Wang <wonglam@amazon.com> * Share feature config generator between publicn and server Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix osd server crashed due to import from public Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 76de9a3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7937 +/- ##
==========================================
- Coverage 61.01% 61.01% -0.01%
==========================================
Files 3670 3670
Lines 86747 86756 +9
Branches 13331 13333 +2
==========================================
+ Hits 52930 52931 +1
- Misses 30621 30629 +8
Partials 3196 3196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
#7958 has been merged in, CI should be fixed once branch is updated. |
|
The backport PR of #7954 should fix current failed unit tests, shall we manual backport these two PRs in one sperate PR? |
|
Hi, I've raised a manual PR(#7984) to combine #7884 and #7954. The UT work fine in the manual backport PR (See job details: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/10694131262/job/29645421003?pr=7984). Current automatic backport PR can be closed. Feel free to help me review #7984 |
|
Close for #7984 |
Backport 76de9a3 from #7884.