[Manual][Backport 2.x] Backport 7884 and 7954 to 2.x #7984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… API (opensearch-project#7884) * Add validate for features field in workspace create and update API Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR opensearch-project#7884 created/updated * Changeset file for PR opensearch-project#7884 created/updated * Move router outside align with other plugins Signed-off-by: Lin Wang <wonglam@amazon.com> * Add ut and fix integration tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Import use case id from default nav groups Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix workspace routes UT Signed-off-by: Lin Wang <wonglam@amazon.com> * Share feature config generator between publicn and server Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix osd server crashed due to import from public Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…es UT (opensearch-project#7954) * Fix dynamicConfigServiceMock import path in workspace routes UT Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR opensearch-project#7954 created/updated --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7984 +/- ##
==========================================
+ Coverage 61.13% 61.15% +0.01%
==========================================
Files 3686 3687 +1
Lines 87139 87149 +10
Branches 13387 13389 +2
==========================================
+ Hits 53275 53295 +20
+ Misses 30632 30619 -13
- Partials 3232 3235 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
|
ciGroup3 failed because of #7979. |
SuZhou-Joe
approved these changes
Sep 4, 2024
ruanyl
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
* [Workspace]Validate features parameter in workspace create and update API (#7884) * Add validate for features field in workspace create and update API Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #7884 created/updated * Changeset file for PR #7884 created/updated * Move router outside align with other plugins Signed-off-by: Lin Wang <wonglam@amazon.com> * Add ut and fix integration tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Import use case id from default nav groups Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix workspace routes UT Signed-off-by: Lin Wang <wonglam@amazon.com> * Share feature config generator between publicn and server Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix osd server crashed due to import from public Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Workspace]Fix dynamicConfigServiceMock import path in workspace routes UT (#7954) * Fix dynamicConfigServiceMock import path in workspace routes UT Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #7954 created/updated --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit d3ce40f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 6, 2024
* [Workspace]Validate features parameter in workspace create and update API (#7884) * Add validate for features field in workspace create and update API * Changeset file for PR #7884 created/updated * Changeset file for PR #7884 created/updated * Move router outside align with other plugins * Add ut and fix integration tests * Import use case id from default nav groups * Fix workspace routes UT * Share feature config generator between publicn and server * Fix osd server crashed due to import from public --------- * [Workspace]Fix dynamicConfigServiceMock import path in workspace routes UT (#7954) * Fix dynamicConfigServiceMock import path in workspace routes UT * Changeset file for PR #7954 created/updated --------- --------- (cherry picked from commit d3ce40f) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for backporting #7884 and #7954 to
2.xbranch.There is a unit test failed in #7884 backport PR, the #7954 would fix this unit test error.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration