Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the lucene snapshot url #12260

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

peternied
Copy link
Member

Description

Update the lucene snapshot url (correctly)

Related Issues

Issues:

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Issues:
- Driver of this change opensearch-project/opensearch-build#3874 (comment)
- Previous change updated the wrong location opensearch-project#11728

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied
Copy link
Member Author

@peterzhuamazon Could you please double check that this is the correct URL?

@peternied peternied added the backport 2.x Backport to 2.x branch label Feb 8, 2024
@peternied
Copy link
Member Author

FYI - This is NOT needed for 2.12

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Compatibility status:

Checks if related components are compatible with change 9babba6

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

github-actions bot commented Feb 8, 2024

❌ Gradle check result for 9babba6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 8, 2024

❌ Gradle check result for 9babba6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 9, 2024

❕ Gradle check result for 9babba6: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (445bf1f) 71.36% compared to head (9babba6) 71.41%.
Report is 7 commits behind head on main.

Files Patch % Lines
...opensearch/ingest/common/CommunityIdProcessor.java 82.97% 22 Missing and 18 partials ⚠️
...h/aggregations/bucket/FastFilterRewriteHelper.java 87.50% 3 Missing and 12 partials ⚠️
...egations/bucket/composite/CompositeAggregator.java 90.47% 1 Missing and 1 partial ⚠️
...org/opensearch/gradle/RepositoriesSetupPlugin.java 0.00% 1 Missing ⚠️
...search/ingest/common/IngestCommonModulePlugin.java 0.00% 1 Missing ⚠️
...ions/bucket/histogram/DateHistogramAggregator.java 87.50% 0 Missing and 1 partial ⚠️
.../org/opensearch/telemetry/tracing/SpanBuilder.java 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12260      +/-   ##
============================================
+ Coverage     71.36%   71.41%   +0.05%     
- Complexity    59643    59756     +113     
============================================
  Files          4954     4955       +1     
  Lines        280695   281022     +327     
  Branches      40780    40841      +61     
============================================
+ Hits         200319   200702     +383     
+ Misses        63688    63598      -90     
- Partials      16688    16722      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied
Copy link
Member Author

@peternied peternied merged commit 4d044e4 into opensearch-project:main Feb 9, 2024
116 checks passed
@peternied peternied deleted the fix-lucence-url branch February 9, 2024 02:12
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 9, 2024
Signed-off-by: Peter Nied <petern@amazon.com>
(cherry picked from commit 4d044e4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peternied pushed a commit that referenced this pull request Feb 9, 2024
(cherry picked from commit 4d044e4)

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
Signed-off-by: Peter Nied <petern@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
Signed-off-by: Peter Nied <petern@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants