-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Add support for dependencies in plugin descriptor properties with semver range #11441 #12271
[Backport 2.x] Add support for dependencies in plugin descriptor properties with semver range #11441 #12271
Conversation
Compatibility status:Checks if related components are compatible with change c82c6e1 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for c59fd0b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…ver range (opensearch-project#11441) * Add support for dependencies in plugin descriptor properties with semver range (opensearch-project#1707) Signed-off-by: Abhilasha Seth <abseth@amazon.com> * Remove unused gson licenses Signed-off-by: Abhilasha Seth <abseth@amazon.com> * Maintain bwc in PluginInfo with addition of semver range Signed-off-by: Abhilasha Seth <abseth@amazon.com> * Added support for list of ranges Signed-off-by: Abhilasha Seth <abseth@amazon.com> * Add bwc tests and restrict range list size to 1 Signed-off-by: Abhilasha Seth <abseth@amazon.com> * Update SemverRange javadoc Signed-off-by: Abhilasha Seth <abseth@amazon.com> * Minor change to trigger jenkins re-run Signed-off-by: Abhilasha Seth <abseth@amazon.com> * Use jackson instead of gson * Remove jackson databind and annotations dependency from server Signed-off-by: Abhilasha Seth <abseth@amazon.com> * nit fixes Signed-off-by: Abhilasha Seth <abseth@amazon.com> * Minor change to re-run jenkins workflow Signed-off-by: Abhilasha Seth <abseth@amazon.com> --------- Signed-off-by: Abhilasha Seth <abseth@amazon.com>
c59fd0b
to
c82c6e1
Compare
❌ Gradle check result for c82c6e1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for c82c6e1: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #12271 +/- ##
============================================
- Coverage 71.19% 71.17% -0.02%
- Complexity 59951 59969 +18
============================================
Files 4940 4944 +4
Lines 282025 282117 +92
Branches 41306 41321 +15
============================================
+ Hits 200790 200809 +19
- Misses 64249 64374 +125
+ Partials 16986 16934 -52 ☔ View full report in Codecov by Sentry. |
@abseth-amzn This is resulting in a breaking change within |
I opened #12528, @abseth-amzn will you please take a look? |
Description
Backport #11441 to 2.x.
Following are the additional changes:
Related Issues
Resolves #1707
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.