Implement interface changes for s3 plugin to read/write blob with obj… #13113

skumawat2025 · 2024-04-08T08:23:57Z

…ect metadata

Description

This PR is a sub task of feature request #13022. And is being tracked here #13091.

This PR implement interfaces changes for s3 plugin introduced as part of PR #13023 to read/write blob object with object metadata.

This PR includes changes for following flows -

async upload flow. (function - asyncBlobUpload()) (currently in use for translog/segments upload in s3 plugin)
sync upload flow. (function - writeBlobAtomic()) (currently in use for other blob stores Azure, GCP)
sync download flow. (function- readBlob()) (currently in use for translog download in s3 plugin)

Related Issues

Resolves #13093

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
~~Commit changes are listed out in CHANGELOG.md file (See: Changelog)~~
~~Public documentation issue/PR created~~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2024-04-08T08:43:30Z

❌ Gradle check result for fe8ba21: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-04-08T08:46:45Z

Compatibility status:

Checks if related components are compatible with change e947a3c

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git]

github-actions · 2024-04-08T09:01:45Z

❌ Gradle check result for 4ac7006: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…ect metadata Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

github-actions · 2024-04-08T10:14:41Z

❕ Gradle check result for ca99c35: UNSTABLE

TEST FAILURES:

      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2024-04-08T10:15:22Z

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.51%. Comparing base (b15cb0c) to head (e947a3c).
Report is 153 commits behind head on main.

Files	Patch %	Lines
...rg/opensearch/repositories/s3/S3BlobContainer.java	85.71%	2 Missing ⚠️
...g/opensearch/common/blobstore/FetchBlobResult.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13113      +/-   ##
============================================
+ Coverage     71.42%   71.51%   +0.09%     
- Complexity    59978    60529     +551     
============================================
  Files          4985     5027      +42     
  Lines        282275   284598    +2323     
  Branches      40946    41219     +273     
============================================
+ Hits         201603   203538    +1935     
- Misses        63999    64253     +254     
- Partials      16673    16807     +134

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashking94 · 2024-04-09T04:35:34Z

@skumawat2025 nit - Instead of non-async, you can mention it as sync.

non-async upload flow. (function - writeBlobAtomic()) (currently in use for other plugins)

Which plugin is it?

libs/common/src/main/java/org/opensearch/common/io/InputStreamContainer.java

plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/async/UploadRequest.java

plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3BlobContainer.java

plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3RetryingInputStream.java

...s/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncTransferManager.java

...pository-s3/src/test/java/org/opensearch/repositories/s3/S3BlobContainerMockClientTests.java

.../repository-s3/src/test/java/org/opensearch/repositories/s3/S3BlobContainerRetriesTests.java

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

github-actions · 2024-04-09T09:22:31Z

✅ Gradle check result for b528cfa: SUCCESS

github-actions · 2024-04-11T12:29:26Z

❕ Gradle check result for f6d01db: UNSTABLE

TEST FAILURES:

      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

skumawat2025 · 2024-04-11T12:30:48Z

❕ Gradle check result for f6d01db: UNSTABLE

TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky Test: #10558

github-actions · 2024-04-11T13:18:20Z

❕ Gradle check result for 38903af: UNSTABLE

TEST FAILURES:

      1 org.opensearch.gateway.RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2024-04-11T13:55:41Z

❌ Gradle check result for 8247c56: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>

github-actions · 2024-04-11T14:42:46Z

✅ Gradle check result for 44be3f2: SUCCESS

...s/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncTransferManager.java

server/src/main/java/org/opensearch/common/blobstore/FetchBlobResult.java

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>

github-actions · 2024-04-11T18:29:45Z

❕ Gradle check result for e947a3c: UNSTABLE

TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotWithLargeSegmentFiles

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

opensearch-trigger-bot · 2024-05-20T11:34:38Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13113-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73453718a1c85565a3f7e4309d6fa83bf9a30522
# Push it to GitHub
git push --set-upstream origin backport/backport-13113-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13113-to-2.x.

opensearch-project#13113) * Implement interface changes for s3 plugin to read/write blob with object metadata --------- Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com> Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>

#13113) (#13765) * Implement interface changes for s3 plugin to read/write blob with object metadata --------- Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

opensearch-project#13113) (opensearch-project#13765) * Implement interface changes for s3 plugin to read/write blob with object metadata --------- Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Signed-off-by: kkewwei <kkewwei@163.com>

github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Performance v2.14.0 labels Apr 8, 2024

skumawat2025 force-pushed the implement-change-s3-plugin branch from fe8ba21 to 4ac7006 Compare April 8, 2024 08:54

skumawat2025 added the skip-changelog label Apr 8, 2024

Implement interface changes for s3 plugin to read/write blob with obj…

ca99c35

…ect metadata Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

skumawat2025 force-pushed the implement-change-s3-plugin branch from 4ac7006 to ca99c35 Compare April 8, 2024 09:23

skumawat2025 requested a review from ashking94 April 8, 2024 10:24

ashking94 requested changes Apr 9, 2024

View reviewed changes

resolve comments

b528cfa

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

skumawat2025 requested review from ashking94 and sachinpkale April 9, 2024 10:40

skumawat2025 marked this pull request as ready for review April 9, 2024 10:40

skumawat2025 requested review from abbashus, adnapibar, anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, dbwiddis, dreamer-89 and gbbafna as code owners April 9, 2024 10:40

skumawat2025 force-pushed the implement-change-s3-plugin branch from 38903af to 8247c56 Compare April 11, 2024 13:23

add test

44be3f2

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>

skumawat2025 force-pushed the implement-change-s3-plugin branch from 8247c56 to 44be3f2 Compare April 11, 2024 13:59

kotwanikunal reviewed Apr 11, 2024

View reviewed changes

...s/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncTransferManager.java Outdated Show resolved Hide resolved

server/src/main/java/org/opensearch/common/blobstore/FetchBlobResult.java Show resolved Hide resolved

address comments

e947a3c

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>

sachinpkale approved these changes Apr 12, 2024

View reviewed changes

sachinpkale merged commit 7345371 into opensearch-project:main Apr 12, 2024
31 of 33 checks passed

sachinpkale added the backport 2.x Backport to 2.x branch label May 20, 2024

opensearch-trigger-bot bot added the backport-failed label May 20, 2024

skumawat2025 removed the backport-failed label May 21, 2024

skumawat2025 mentioned this pull request May 21, 2024

Implement interface changes for s3 plugin to read/write blob with obj… #13765

Merged

8 tasks

skumawat2025 added v2.15.0 Issues and PRs related to version 2.15.0 and removed v2.14.0 labels Jun 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement interface changes for s3 plugin to read/write blob with obj… #13113

Implement interface changes for s3 plugin to read/write blob with obj… #13113

skumawat2025 commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

codecov bot commented Apr 8, 2024 •

edited

Loading

ashking94 commented Apr 9, 2024 •

edited

Loading

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 11, 2024

skumawat2025 commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

opensearch-trigger-bot bot commented May 20, 2024

Implement interface changes for s3 plugin to read/write blob with obj… #13113

Implement interface changes for s3 plugin to read/write blob with obj… #13113

Conversation

skumawat2025 commented Apr 8, 2024 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

codecov bot commented Apr 8, 2024 • edited Loading

Codecov Report

ashking94 commented Apr 9, 2024 • edited Loading

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 11, 2024

skumawat2025 commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

opensearch-trigger-bot bot commented May 20, 2024

skumawat2025 commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Apr 8, 2024 •

edited

Loading

codecov bot commented Apr 8, 2024 •

edited

Loading

ashking94 commented Apr 9, 2024 •

edited

Loading