Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement interface changes for s3 plugin to read/write blob with obj… #13765

Merged
merged 1 commit into from
May 22, 2024
Merged

Implement interface changes for s3 plugin to read/write blob with obj… #13765

merged 1 commit into from
May 22, 2024

Conversation

skumawat2025
Copy link
Contributor

Backport #13113 to 2.x

Merge Conflicts Files:
UploadRequest.java

Signed-off-by: Sandeep Kumawat skumwt@amazon.com

Related Issues

Resolves []

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@skumawat2025 skumawat2025 self-assigned this May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for a4f6867: SUCCESS

@codecov Codecov
Copy link

codecov bot commented May 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.27%. Comparing base (0dd892c) to head (dafc1b4).
Report is 267 commits behind head on 2.x.

Files Patch % Lines
...rg/opensearch/repositories/s3/S3BlobContainer.java 85.71% 2 Missing ⚠️
...g/opensearch/common/blobstore/FetchBlobResult.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #13765      +/-   ##
============================================
- Coverage     71.28%   71.27%   -0.01%     
- Complexity    60145    61264    +1119     
============================================
  Files          4957     5037      +80     
  Lines        282799   288274    +5475     
  Branches      41409    42114     +705     
============================================
+ Hits         201591   205479    +3888     
- Misses        64189    65482    +1293     
- Partials      17019    17313     +294

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 208693e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b193fe8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025
Copy link
Contributor Author

❌ Gradle check result for b193fe8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky: testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards -> #10152

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 701bad1: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 81fb46a:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 8818286: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for db3d9a9: SUCCESS

@skumawat2025
Implement interface changes for s3 plugin to read/write blob with obj… (
dafc1b4 
opensearch-project#13113)

* Implement interface changes for s3 plugin to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for dafc1b4: SUCCESS

@skumawat2025 skumawat2025 marked this pull request as ready for review May 22, 2024 10:03
@sachinpkale sachinpkale merged commit 9f25c38 into opensearch-project:2.x May 22, 2024
51 checks passed
@prudhvigodithi prudhvigodithi mentioned this pull request Jun 18, 2024
Closed
This was referenced Jun 27, 2024
Open
Open
Open
Open
Open
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@skumawat2025 @kkewwei
Implement interface changes for s3 plugin to read/write blob with obj… (
8932c34 
opensearch-project#13113) (opensearch-project#13765)

* Implement interface changes for s3 plugin to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@skumawat2025 skumawat2025

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skumawat2025 @sachinpkale