Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unnecessary string format in ThrottlingAllocationDecider when not in debug mode #13750

Merged
merged 2 commits into from
May 21, 2024

Conversation

imRishN
Copy link
Member

@imRishN imRishN commented May 20, 2024

Description

Skip unnecessary string format in ThrottlingAllocationDecider when not in debug mode

Related Issues

Resolves #13743

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN imRishN changed the title Skip unnecessary string format when not in debug mode Skip unnecessary string format in ThrottlingAllocationDecider when not in debug mode May 20, 2024
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Copy link
Contributor

❌ Gradle check result for 7239ec7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request ShardManagement:Performance labels May 20, 2024
Copy link
Contributor

❌ Gradle check result for de2f3a1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add a test to validate of the debug decision message is consistent with the status quo. Please point me to an existing one if they exist

Copy link
Contributor

✅ Gradle check result for de2f3a1: SUCCESS

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.52%. Comparing base (b15cb0c) to head (de2f3a1).
Report is 294 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13750      +/-   ##
============================================
+ Coverage     71.42%   71.52%   +0.10%     
- Complexity    59978    61233    +1255     
============================================
  Files          4985     5061      +76     
  Lines        282275   287871    +5596     
  Branches      40946    41692     +746     
============================================
+ Hits         201603   205895    +4292     
- Misses        63999    64969     +970     
- Partials      16673    17007     +334     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imRishN
Copy link
Member Author

imRishN commented May 21, 2024

LGTM, can we add a test to validate of the debug decision message is consistent with the status quo. Please point me to an existing one if they exist

- this test asserts the decision explanation. This should suffice?

@Bukhtawar
Copy link
Collaborator

Flaky test #12197

@Bukhtawar Bukhtawar merged commit 04e28fa into opensearch-project:main May 21, 2024
78 of 83 checks passed
@imRishN imRishN added the backport 2.x Backport to 2.x branch label May 21, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 21, 2024
…t in debug mode (#13750)

* Skip unnecessary String format in throttling allocation decider when not in debug mode

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
(cherry picked from commit 04e28fa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Bukhtawar pushed a commit that referenced this pull request May 22, 2024
…t in debug mode (#13750) (#13762)

* Skip unnecessary String format in throttling allocation decider when not in debug mode

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…t in debug mode (opensearch-project#13750)

* Skip unnecessary String format in throttling allocation decider when not in debug mode

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…t in debug mode (opensearch-project#13750) (opensearch-project#13762)

* Skip unnecessary String format in throttling allocation decider when not in debug mode

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request ShardManagement:Performance skip-changelog
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Feature Request] Optimise Throttling Allocation Decider
2 participants