-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip unnecessary string format in ThrottlingAllocationDecider when not in debug mode #13750
Skip unnecessary string format in ThrottlingAllocationDecider when not in debug mode #13750
Conversation
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
❌ Gradle check result for 7239ec7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for de2f3a1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can we add a test to validate of the debug decision message is consistent with the status quo. Please point me to an existing one if they exist
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13750 +/- ##
============================================
+ Coverage 71.42% 71.52% +0.10%
- Complexity 59978 61233 +1255
============================================
Files 4985 5061 +76
Lines 282275 287871 +5596
Branches 40946 41692 +746
============================================
+ Hits 201603 205895 +4292
- Misses 63999 64969 +970
- Partials 16673 17007 +334 ☔ View full report in Codecov by Sentry. |
Line 276 in 3fe6674
|
Flaky test #12197 |
…t in debug mode (opensearch-project#13750) * Skip unnecessary String format in throttling allocation decider when not in debug mode Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…t in debug mode (opensearch-project#13750) (opensearch-project#13762) * Skip unnecessary String format in throttling allocation decider when not in debug mode Signed-off-by: Rishab Nahata <rnnahata@amazon.com> Signed-off-by: kkewwei <kkewwei@163.com>
Description
Skip unnecessary string format in ThrottlingAllocationDecider when not in debug mode
Related Issues
Resolves #13743
Check List
[ ] New functionality includes testing.[ ] All tests pass[ ] New functionality has been documented.[ ] New functionality has javadoc added[ ] API changes companion pull request created.[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.