Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Skip unnecessary string format in ThrottlingAllocationDecider when not in debug mode #13762

Merged
merged 1 commit into from
May 22, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 04e28fa from #13750.

…t in debug mode (#13750)

* Skip unnecessary String format in throttling allocation decider when not in debug mode

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
(cherry picked from commit 04e28fa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Gradle check result for de6b5a2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented May 21, 2024

@imRishN

@dblock
Copy link
Member

dblock commented May 21, 2024

❌ Gradle check result for de6b5a2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.action.admin.indices.create.RemoteCloneIndexIT.testCreateCloneIndexFailure

#13476

Copy link
Contributor

❌ Gradle check result for de6b5a2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for de6b5a2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented May 21, 2024

❌ Gradle check result for de6b5a2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.remotemigration.RemoteReplicaRecoveryIT.testReplicaRecovery

#13473

Copy link
Contributor

❕ Gradle check result for de6b5a2: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteBlobWithRetries

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bukhtawar Bukhtawar merged commit faa592a into 2.x May 22, 2024
49 of 50 checks passed
@github-actions github-actions bot deleted the backport/backport-13750-to-2.x branch May 22, 2024 05:37
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…t in debug mode (opensearch-project#13750) (opensearch-project#13762)

* Skip unnecessary String format in throttling allocation decider when not in debug mode

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants