Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated constant META_FIELDS_BEFORE_7DOT8 #13860

Merged
merged 5 commits into from
May 29, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented May 28, 2024

Description

Remove deprecated constant META_FIELDS_BEFORE_7DOT8

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@reta reta added the backport 2.x Backport to 2.x branch label May 28, 2024
Copy link
Contributor

❌ Gradle check result for 493970c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 3321035: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks cwperks closed this May 28, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks reopened this May 28, 2024
@reta reta merged commit 9832972 into opensearch-project:main May 29, 2024
30 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13860-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 983297289325bdd1c832bfe18d105bd3e9727ab5
# Push it to GitHub
git push --set-upstream origin backport/backport-13860-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13860-to-2.x.

@reta
Copy link
Collaborator

reta commented May 29, 2024

❌ Gradle check result for 55e855d: FAILURE

#13871

@reta
Copy link
Collaborator

reta commented May 29, 2024

❌ Gradle check result for 55e855d: FAILURE

#13600

@reta
Copy link
Collaborator

reta commented May 29, 2024

@cwperks could you please backport to 2.x manually? Thank you.

cwperks added a commit to cwperks/OpenSearch that referenced this pull request May 29, 2024
…ct#13860)

* Add _primary_term to builtInMetadataMappers

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove deprecated constant META_FIELDS_BEFORE_7DOT8

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 9832972)
@cwperks
Copy link
Member Author

cwperks commented May 29, 2024

Opened up manual backport: #13873

cwperks added a commit to cwperks/OpenSearch that referenced this pull request May 29, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 and removed backport 2.x Backport to 2.x branch backport-failed labels May 29, 2024
reta pushed a commit that referenced this pull request May 29, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks added a commit to cwperks/OpenSearch that referenced this pull request May 31, 2024
reta pushed a commit that referenced this pull request May 31, 2024
…#13916)

* Revert "Remove deprecated constant META_FIELDS_BEFORE_7DOT8 (#13860)"

This reverts commit 9832972.

* Update CHANGELOG-3.0

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…ct#13860)

* Add _primary_term to builtInMetadataMappers

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove deprecated constant META_FIELDS_BEFORE_7DOT8

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…ch-project#13860)" (opensearch-project#13916)

* Revert "Remove deprecated constant META_FIELDS_BEFORE_7DOT8 (opensearch-project#13860)"

This reverts commit 9832972.

* Update CHANGELOG-3.0

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…ct#13860)

* Add _primary_term to builtInMetadataMappers

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove deprecated constant META_FIELDS_BEFORE_7DOT8

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…ch-project#13860)" (opensearch-project#13916)

* Revert "Remove deprecated constant META_FIELDS_BEFORE_7DOT8 (opensearch-project#13860)"

This reverts commit 9832972.

* Update CHANGELOG-3.0

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants