Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Remove deprecated constant META_FIELDS_BEFORE_7DOT8 (#13860) #13873

Closed
wants to merge 1 commit into from
Closed

[Backport 2.x] Remove deprecated constant META_FIELDS_BEFORE_7DOT8 (#13860) #13873

wants to merge 1 commit into from

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented May 29, 2024

Backport #13860 to 2.x

@cwperks
Remove deprecated constant META_FIELDS_BEFORE_7DOT8 (opensearch-proje…
745ce28 
…ct#13860)

* Add _primary_term to builtInMetadataMappers

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove deprecated constant META_FIELDS_BEFORE_7DOT8

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 9832972)
@cwperks cwperks mentioned this pull request May 29, 2024
Merged
9 tasks
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 745ce28: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks
Copy link
Member Author

cwperks commented May 29, 2024 

WARNING: The following functionality has been deprecated and will be removed in the next major release of the Develocity Gradle plugin. Run with '-Ddevelocity.deprecation.captureOrigin=true' to see where the deprecated functionality is being used. For assistance with migration, see https://gradle.com/help/gradle-plugin-develocity-migration.
- The deprecated "gradle.enterprise.testretry.enabled" system property has been replaced by "develocity.testretry.enabled"
- The "com.gradle.enterprise" plugin has been replaced by "com.gradle.develocity"
FAILURE: Build failed with an exception.

@reta
Copy link
Collaborator

reta commented May 29, 2024 

WARNING: The following functionality has been deprecated and will be removed in the next major release of the Develocity Gradle plugin. Run with '-Ddevelocity.deprecation.captureOrigin=true' to see where the deprecated functionality is being used. For assistance with migration, see https://gradle.com/help/gradle-plugin-develocity-migration.
- The deprecated "gradle.enterprise.testretry.enabled" system property has been replaced by "develocity.testretry.enabled"
- The "com.gradle.enterprise" plugin has been replaced by "com.gradle.develocity"
FAILURE: Build failed with an exception.

I will fix that in #13584 , thanks for noticing

@reta
Copy link
Collaborator

reta commented May 29, 2024

@cwperks seems like 2.x is still using this property

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 745ce28: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks
Copy link
Member Author

cwperks commented May 29, 2024

I see, it was removed from main in db418fb#diff-1512f075b54901bdac674bdae377e3c0ea1d9f984b8f3a832663e1a8e9b7d77b.

I will close this backport and target this change only on main. I'll open a separate PR to move the CHANGELOG entry from the 2.x CHANGELOG -> CHANGELOG 3.0.

@cwperks cwperks closed this May 29, 2024
@reta
Copy link
Collaborator

reta commented May 29, 2024

I see, it was removed from main in db418fb#diff-1512f075b54901bdac674bdae377e3c0ea1d9f984b8f3a832663e1a8e9b7d77b.

Sorry about that, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwperks @reta