[Backport 2.x] [DerivedField] Support DerivedField object type and integration with Mapper #14105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…Mapper (#13720) * Support DerivedField object type * ValueFetcher for DerivedField of object type to parse and fetch nested fields. * DerivedFieldResolver to resolve DerivedField type on the fly. * Introduction of new support types - text, float. * Use index analyzer for derived fields set in index settings. * Support of derived fields from query string * Unit tests Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Derived field object type properties to also support Object as a value Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Index and cluster setting to control derived fields Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Fix test Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Fixed missing javadoc Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Fix the rewrite issue when profile is set as true Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Address PR comments Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Address PR comments Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Use conjuction query with filter on source_indexed_field query and DerivedFieldQuery Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * support source_indexed_field for non-object type derived fields Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * rename source_indexed_field to prefilter_field Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit 9da6170) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
rishabhmaurya
added
backport 2.x
|
There are changes in following classes because of which breaking change check is failing - Since |
dblock
approved these changes
Jun 10, 2024
|
This PR should not have been merged with the failing compat check, as future PRs to 2.x will fail now because the check compares against the 2.14 released artifacts. @rishabhmaurya is going to raise a PR to add back the public methods that were removed. |
My bad. Will be more careful with this moving forward. |
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…Mapper (opensearch-project#13720) (opensearch-project#14105) * Support DerivedField object type * ValueFetcher for DerivedField of object type to parse and fetch nested fields. * DerivedFieldResolver to resolve DerivedField type on the fly. * Introduction of new support types - text, float. * Use index analyzer for derived fields set in index settings. * Support of derived fields from query string * Unit tests * Derived field object type properties to also support Object as a value * Index and cluster setting to control derived fields * Fix test * Fixed missing javadoc * Fix the rewrite issue when profile is set as true * Address PR comments * Address PR comments * Use conjuction query with filter on source_indexed_field query and DerivedFieldQuery * support source_indexed_field for non-object type derived fields * rename source_indexed_field to prefilter_field --------- (cherry picked from commit 9da6170) Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9da6170 from #13720.