Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add recovery chunk size setting #14131

Closed
wants to merge 2 commits into from
Closed

[Backport 2.x] Add recovery chunk size setting #14131

wants to merge 2 commits into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 53ea952 from #13997.

@github-actions
Add recovery chunk size setting (#13997)
42b7e87 
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
(cherry picked from commit 53ea952)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
dblock requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a breaking API change here @gbbafna @astute-decipher. Want to make sure we're ok with it?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 42b7e87: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna
Copy link
Collaborator

gbbafna commented Jun 10, 2024 •
edited
Loading

Looks like there's a breaking API change here @gbbafna @astute-decipher. Want to make sure we're ok with it?

Hi @dblock , this PR doesn't cause any breaking API change. It just adds a new setting

Sorry, my bad. It is due to this PR only . We have removed a field DEFAULT_CHUNK_SIZE which was only meant for tests to override the chunk size . In this PR we have made chunk size configurable, so we should be good with this breaking change .

However, would this cause other PRs's breaking changes workflow to fail as well ? In this case, how do we proceed ?

@dblock
Copy link
Member

dblock commented Jun 10, 2024

The only question is whether there are users that may or may no rely on this setting out there. So what makes us be sure that DEFAULT_CHUNK_SIZE was not used by anyone?

@dblock
Copy link
Member

dblock commented Jun 10, 2024

Looks like I am wrong about the backwards incompatible change being ok, see #14105 (comment). cc: @andrross, how should this PR be solving it?

@gbbafna @andrross
Update server/src/main/java/org/opensearch/indices/recovery/RecoveryS…
b058d55 
…ettings.java

Co-authored-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b058d55: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b058d55:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna
Copy link
Collaborator

gbbafna commented Jun 11, 2024

Closing in favor of #14161

@gbbafna gbbafna closed this Jun 11, 2024
This was referenced Jun 13, 2024
Open
Open
@prudhvigodithi prudhvigodithi mentioned this pull request Jun 14, 2024
Closed
@dbwiddis dbwiddis deleted the backport/backport-13997-to-2.x branch July 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross left review comments

@dblock dblock dblock requested changes

@gbbafna gbbafna gbbafna approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbbafna @dblock @andrross