Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add query group stats constructs #15343

Merged
merged 9 commits into from
Aug 28, 2024
Merged

add query group stats constructs #15343

merged 9 commits into from
Aug 28, 2024

Conversation

kaushalmahi12
Copy link
Contributor

Description

This change introduces constructs to hold live view of query group level stats and point in time view of query group stats. Post these changes we will need changes to hook these constructs with various request events i,e; completions, failures, cancellations and rejections.

Related Issues

Resolves ##15120
RFC: #12342

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kaushalmahi12 kaushalmahi12 added the backport 2.x Backport to 2.x branch label Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 9f34c30: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 52330cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 31f5405: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kaushalmahi12
add query group stats constructs
c34aa0e 
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
@kaushalmahi12
add changelog entry
676096f 
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
@kaushalmahi12
add packageinfo for stats
7fada74 
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
@kaushalmahi12 kaushalmahi12 force-pushed the feature/sandbox-stats_constructs branch from 31f5405 to 7fada74 Compare August 22, 2024 22:37
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7fada74: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kaushalmahi12
add total cancellations
ce813f1 
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ce813f1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Collaborator

Also, gradle precommit is failing for this PR

@kaushalmahi12
add more granular level rejections
a783e8f 
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
@kaushalmahi12
add toXContent test cases
c53daf8 
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
@kaushalmahi12
Merge branch 'main' into feature/sandbox-stats_constructs
1df409f 
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
@kaushalmahi12
move ResourceType enum to wlm
353b1c8 
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
@kaushalmahi12
update the comment for query group stats
4f6ee7a 
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 1df409f: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 353b1c8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 4f6ee7a: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.18919% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.87%. Comparing base (c771bdd) to head (4f6ee7a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...java/org/opensearch/wlm/stats/QueryGroupStats.java 87.20% 4 Missing and 7 partials ⚠️
...java/org/opensearch/wlm/stats/QueryGroupState.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #15343      +/-   ##
============================================
- Coverage     71.95%   71.87%   -0.09%     
- Complexity    63286    63302      +16     
============================================
  Files          5225     5227       +2     
  Lines        296215   296323     +108     
  Branches      42788    42800      +12     
============================================
- Hits         213133   212971     -162     
- Misses        65559    65892     +333     
+ Partials      17523    17460      -63

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jainankitk jainankitk merged commit c0bcacb into opensearch-project:main Aug 28, 2024
34 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 28, 2024
@github-actions
Add query group stats constructs (#15343)
7e8212d 
* add query group stats constructs

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add changelog entry

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add packageinfo for stats

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add total cancellations

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add more granular level rejections

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add toXContent test cases

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* move ResourceType enum to wlm

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* update the comment for query group stats

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

---------

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
(cherry picked from commit c0bcacb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 28, 2024
Merged
jainankitk pushed a commit that referenced this pull request Aug 28, 2024
@opensearch-trigger-bot @github-actions
Add query group stats constructs (#15343) (#15473)
c63ad5a 
* add query group stats constructs



* add changelog entry



* add packageinfo for stats



* add total cancellations



* add more granular level rejections



* add toXContent test cases



* move ResourceType enum to wlm



* update the comment for query group stats



---------


(cherry picked from commit c0bcacb)

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta added a commit that referenced this pull request Aug 28, 2024
@reta
Revert "Add query group stats constructs (#15343) (#15473)"
7ddcf80 
This reverts commit c63ad5a.
reta added a commit that referenced this pull request Aug 28, 2024
@reta
Revert "Add query group stats constructs (#15343) (#15473)"
9cd2635 
This reverts commit c63ad5a.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@kaushalmahi12 @akolarkunnu
Add query group stats constructs (opensearch-project#15343)
9ae9202 
* add query group stats constructs

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add changelog entry

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add packageinfo for stats

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add total cancellations

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add more granular level rejections

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add toXContent test cases

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* move ResourceType enum to wlm

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* update the comment for query group stats

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

---------

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
This was referenced Sep 11, 2024
Open
Open
Open
Open
@BrewTestBot BrewTestBot mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainankitk jainankitk jainankitk approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaushalmahi12 @jainankitk