Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests due to hashed prefix path type snapshots #15560

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Sep 1, 2024

Description

In the build of main branch after PR merge, saw couple of more tests that have become flaky. Build link - https://build.ci.opensearch.org/job/gradle-check/46090/. In this PR, we are fixing the tests -

  1. org.opensearch.snapshots.RepositoriesIT.testRepositoryCreation - In this test, there is a check to validate that the cluster state uuid has not changed since the update repository does not mutate the repository. I have addded a simple check that checks if the metadata settings have changed or not. If not changed, then the cluster state uuid should also not change.
  2. org.opensearch.snapshots.SnapshotStatusApisIT.testExceptionOnMissingShardLevelSnapBlob - This test was trying to resolve the path for 0th shard of an index by assuming fixed path structure. This has now been changed to use abstract method which disambiguates the path.

Check List

  • Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashking94 ashking94 changed the title Fix flaky tests with hashed prefix path type snapshots Fix flaky tests due to hashed prefix path type snapshots Sep 1, 2024
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for 0cb4127: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 1, 2024

❕ Gradle check result for 9fbae1d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.79%. Comparing base (71d122b) to head (9fbae1d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15560      +/-   ##
============================================
- Coverage     71.99%   71.79%   -0.20%     
+ Complexity    63700    63619      -81     
============================================
  Files          5248     5249       +1     
  Lines        297416   297643     +227     
  Branches      42984    43011      +27     
============================================
- Hits         214113   213699     -414     
- Misses        65776    66364     +588     
- Partials      17527    17580      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashking94
Copy link
Member Author

❕ Gradle check result for 9fbae1d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky test - #14293

@gbbafna gbbafna merged commit 758c2aa into opensearch-project:main Sep 2, 2024
62 of 63 checks passed
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Sep 4, 2024
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Sep 4, 2024
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants