[Backport 2.x] Add support to upload snapshot shard blobs with hashed prefix #15643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch-project#15426) * Add snapshot shard blobs with hashed prefix Signed-off-by: Ashish Singh <ssashish@amazon.com> * Add UTs Signed-off-by: Ashish Singh <ssashish@amazon.com> * Address comments and add UTs Signed-off-by: Ashish Singh <ssashish@amazon.com> * Change default snapshot shard path type to hashed_prefix for testing Signed-off-by: Ashish Singh <ssashish@amazon.com> * Fix failing tests Signed-off-by: Ashish Singh <ssashish@amazon.com> * Introduce single method for all create/put repository calls Signed-off-by: Ashish Singh <ssashish@amazon.com> * Move the index shard path upload to sync upload Signed-off-by: Ashish Singh <ssashish@amazon.com> * Fix spotless errors Signed-off-by: Ashish Singh <ssashish@amazon.com> * Do minor code refactor Signed-off-by: Ashish Singh <ssashish@amazon.com> * Fix tests Signed-off-by: Ashish Singh <ssashish@amazon.com> * More tests to use common methods for repo creation Signed-off-by: Ashish Singh <ssashish@amazon.com> * Address comments and fix multiple failing tests Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
…t#15426 (opensearch-project#15559) Signed-off-by: Ashish Singh <ssashish@amazon.com>
…oject#15560) Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
…5559-15560 Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
|
❌ Gradle check result for 4cab651: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
|
❕ Gradle check result for f9b49ed: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
The conflicts were present in below classes -
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #15643 +/- ##
============================================
+ Coverage 71.70% 71.76% +0.06%
- Complexity 64104 64199 +95
============================================
Files 5249 5250 +1
Lines 299681 299917 +236
Branches 43643 43672 +29
============================================
+ Hits 214876 215239 +363
+ Misses 66848 66697 -151
- Partials 17957 17981 +24 ☔ View full report in Codecov by Sentry. |
gbbafna
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c308b98 from #15426.
Backport 4c98c7e from #15559.
Backport 758c2aa from #15560.