Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SnapshotV2] Version change to V_2.17.0 for node min version check in create snapshot V2 #15644

Merged
merged 3 commits into from
Sep 5, 2024
Merged

[SnapshotV2] Version change to V_2.17.0 for node min version check in create snapshot V2 #15644

merged 3 commits into from
Sep 5, 2024

Conversation

anshu1106
Copy link
Contributor

@anshu1106 anshu1106 commented Sep 4, 2024 •
edited
Loading

Description

This PR changes min node version check to V_2.17.0 in create snapshot v2.

Related Issues

Resolves #15123

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Snapshots labels Sep 4, 2024
@anshu1106 anshu1106 marked this pull request as ready for review September 4, 2024 06:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 872aee6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ Gradle check result for 230a358: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.78%. Comparing base (e087272) to head (7529554).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...ava/org/opensearch/snapshots/SnapshotsService.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #15644      +/-   ##
============================================
- Coverage     72.00%   71.78%   -0.22%     
+ Complexity    64149    64002     -147     
============================================
  Files          5269     5269              
  Lines        299834   299867      +33     
  Branches      43330    43340      +10     
============================================
- Hits         215895   215269     -626     
- Misses        66217    66870     +653     
- Partials      17722    17728       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merge branch 'main' into create-version-2
253abcc 
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 253abcc: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Merge branch 'main' into create-version-2
7529554 
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 7529554: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 7529554: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 7529554: SUCCESS

@sachinpkale sachinpkale merged commit 73e14ab into opensearch-project:main Sep 5, 2024
33 of 34 checks passed
@anshu1106 anshu1106 added the backport 2.x Backport to 2.x branch label Sep 5, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
@github-actions
version change to V_2.17.0 for node min version check (#15644)
fe746e8 
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
(cherry picked from commit 73e14ab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 5, 2024
Closed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
@github-actions
version change to V_2.17.0 for node min version check (#15644)
05efd37 
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
(cherry picked from commit 73e14ab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 5, 2024
Merged
sachinpkale pushed a commit that referenced this pull request Sep 5, 2024
@opensearch-trigger-bot @github-actions
version change to V_2.17.0 for node min version check (#15644) (#15715)
f9d15df 
(cherry picked from commit 73e14ab)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
@anshu1106 anshu1106 mentioned this pull request Sep 6, 2024
Closed
3 tasks
sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Sep 6, 2024
@anshu1106
version change to V_2.17.0 for node min version check (opensearch-pro…
e0fee9c 
…ject#15644)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
sachinpkale added a commit that referenced this pull request Sep 6, 2024
@sachinpkale @mch2
@ltaragi @gbbafna @anshu1106
Flaky tests fix in 2.x branch (#15805)
a24c858 
* Mute test testRemoteStoreCleanupForDeletedIndexForSnapshotV2 (#15695)

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Mute flaky test RemoteFsTimestampAwareTranslogTests.testSimpleOperationsUpload (#15732)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>

* Mute failing snapshot status tests (#15652)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com>

* Restore snapshot changes for shallow snapshot V2 (#15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>

* version change to V_2.17.0 for node min version check (#15644)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>

---------

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
Co-authored-by: Anshu Agarwal <anshuagarwal11@gmail.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
This was referenced Sep 6, 2024
Open
Open
Closed
Open
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@anshu1106 @akolarkunnu
version change to V_2.17.0 for node min version check (opensearch-pro…
d60a349 
…ject#15644)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
This was referenced Sep 11, 2024
Open
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 1, 2024
Open
@prudhvigodithi prudhvigodithi mentioned this pull request Oct 16, 2024
Open
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@anshu1106 @dk2k
version change to V_2.17.0 for node min version check (opensearch-pro…
194322c 
…ject#15644)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@anshu1106 @dk2k
version change to V_2.17.0 for node min version check (opensearch-pro…
c6e6a78 
…ject#15644)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@anshu1106 @dk2k
version change to V_2.17.0 for node min version check (opensearch-pro…
b2e6adc 
…ject#15644)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.17 enhancement Enhancement or improvement to existing feature or request skip-changelog Storage:Snapshots
Projects
Storage Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Snapshot-V2] Centralize snapshot creation and integrate with timestamp pinning
2 participants
@anshu1106 @sachinpkale