[Remove] Types from DocWrite Request and Response #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes type support from DocWrite Request and Response, all derived classes, and all places used. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
added
v2.0.0
|
Can one of the admins verify this patch? |
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
reta
reviewed
Feb 24, 2022
server/src/main/java/org/opensearch/action/delete/DeleteRequestBuilder.java
Show resolved
Hide resolved
reta
reviewed
Feb 24, 2022
reta
reviewed
Feb 24, 2022
reta
reviewed
Feb 24, 2022
server/src/test/java/org/opensearch/action/delete/DeleteRequestTests.java
Outdated
Show resolved
Hide resolved
reta
approved these changes
Feb 24, 2022
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
CEHENKLE
approved these changes
Feb 24, 2022
This was referenced Feb 25, 2022
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Feb 25, 2022
_type was removed in opensearch-project/OpenSearch#2239 OpenSearch Archiver loads data to OpenSearch from data.json into OpenSearch for E2E tests and integration tests but will need to verify if this causes breakage in migration from older versions of the application. Issue resolved: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Feb 25, 2022
_type was removed in opensearch-project/OpenSearch#2239 OpenSearch Archiver loads data to OpenSearch from data.json into OpenSearch for E2E tests and integration tests but will need to verify if this causes breakage in migration from older versions of the application. Issue resolved: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Feb 26, 2022
_type was removed in opensearch-project/OpenSearch#2239 OpenSearch Archiver loads data to OpenSearch from data.json into OpenSearch for E2E tests and integration tests but will need to verify if this causes breakage in migration from older versions of the application. Issue resolved: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Feb 26, 2022
_type was removed in opensearch-project/OpenSearch#2239 OpenSearch Archiver loads data to OpenSearch from data.json into OpenSearch for E2E tests and integration tests but will need to verify if this causes breakage in migration from older versions of the application. Issue resolved: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to opensearch-project/OpenSearch-Dashboards
that referenced
this pull request
Feb 26, 2022
_type was removed in opensearch-project/OpenSearch#2239 OpenSearch Archiver loads data to OpenSearch from data.json into OpenSearch for E2E tests and integration tests but will need to verify if this causes breakage in migration from older versions of the application. Issue resolved: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes type support from DocWrite Request and Response, all derived classes,
and all places used.
relates #1940