Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump geoip2 from 2.16.1 to 3.0.0 in /modules/ingest-geoip #2275

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 28, 2022

Bumps geoip2 from 2.16.1 to 3.0.0.

Release notes

Sourced from geoip2's releases.

3.0.0

  • Java 11 or greater is now required.
  • Apache HttpClient has been replaced with java.net.http.HttpClient.
  • The close() method on WebServiceClient is now deprecated. It no longer does anything.
  • On WebServiceClient.Builder:
    • connectTimeout(int) has been deprecated in favor of connectTimeout(Duration).
    • readTimeout(int) has been deprecated in favor of requestTimeout(Duration).
    • proxy(Proxy) has been deprecated in favor of proxy(ProxySelector).
  • On HttpException and InvalidRequestException, getUrl() has been deprecated in favor of getUri(). Constructors that took a URL have been replaced with the equivalent taking a URI.
  • Deprecated constructors on model and trait classes were removed.
  • Model data types were updated to better reflect database data types. In particular:
    • getGeoNameId() on City, Continent, Country, RepresentedCountry, and Subdivision now returns a Long rather than an Integer.
    • getAutonomousSystemNumber() on AsnResponse and Traits now returns a Long rather than an Integer.
Changelog

Sourced from geoip2's changelog.

3.0.0 (2022-01-24)

  • Java 11 or greater is now required.
  • Apache HttpClient has been replaced with java.net.http.HttpClient.
  • The close() method on WebServiceClient is now deprecated. It no longer does anything.
  • On WebServiceClient.Builder:
    • connectTimeout(int) has been deprecated in favor of connectTimeout(Duration).
    • readTimeout(int) has been deprecated in favor of requestTimeout(Duration).
    • proxy(Proxy) has been deprecated in favor of proxy(ProxySelector).
  • On HttpException and InvalidRequestException, getUrl() has been deprecated in favor of getUri(). Constructors that took a URL have been replaced with the equivalent taking a URI.
  • Deprecated constructors on model and trait classes were removed.
  • Model data types were updated to better reflect database data types. In particular:
    • getGeoNameId() on City, Continent, Country, RepresentedCountry, and Subdivision now returns a Long rather than an Integer.
    • getAutonomousSystemNumber() on AsnResponse and Traits now returns a Long rather than an Integer.
Commits
  • 4fb0817 [maven-release-plugin] prepare release v3.0.0
  • e833dc0 update version number in README.md
  • abcac60 Set release date
  • cc9ccce Merge pull request #293 from maxmind/dependabot/maven/org.codehaus.mojo-versi...
  • 501bbe2 Bump versions-maven-plugin from 2.8.1 to 2.9.0
  • 22fbe74 Merge pull request #291 from maxmind/dependabot/maven/org.apache.maven.plugin...
  • 495ae09 Merge pull request #292 from maxmind/dependabot/maven/org.apache.maven.plugin...
  • c60f6e1 Bump maven-compiler-plugin from 3.8.1 to 3.9.0
  • 06380f5 Bump maven-jar-plugin from 3.2.1 to 3.2.2
  • e80b47c Merge pull request #290 from maxmind/greg/product-renaming
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [geoip2](https://github.com/maxmind/GeoIP2-java) from 2.16.1 to 3.0.0.
- [Release notes](https://github.com/maxmind/GeoIP2-java/releases)
- [Changelog](https://github.com/maxmind/GeoIP2-java/blob/main/CHANGELOG.md)
- [Commits](maxmind/GeoIP2-java@v2.16.1...v3.0.0)

---
updated-dependencies:
- dependency-name: com.maxmind.geoip2:geoip2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner February 28, 2022 13:19
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 28, 2022
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Signed-off-by: dependabot[bot] <support@github.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f455732
Log 2851

Reports 2851

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 56b4a1a
Log 2862

Reports 2862

@kotwanikunal
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 56b4a1a
Log 3356

Reports 3356

@tlfeng
Copy link
Collaborator

tlfeng commented Mar 19, 2022

In log 3356:

> Task :modules:ingest-geoip:compileJava
/var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/modules/ingest-geoip/src/main/java/org/opensearch/ingest/geoip/GeoIpProcessor.java:367: error: incompatible types: Long cannot be converted to Integer
        Integer asn = response.getAutonomousSystemNumber();
                                                        ^
1 error
* What went wrong:
Execution failed for task ':modules:ingest-geoip:thirdPartyAudit'.
> All excluded classes seem to have no issues. This is sometimes an indication that the check silently failed

Looks like need manual intervention.

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API changed w/ new version. This needs a manual update. We can push to this branch and fix the changes.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 29, 2022

Superseded by #2646.

@dependabot dependabot bot closed this Mar 29, 2022
@dependabot dependabot bot deleted the dependabot/gradle/modules/ingest-geoip/com.maxmind.geoip2-geoip2-3.0.0 branch March 29, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants