-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump geoip2 from 2.16.1 to 3.0.1 in /modules/ingest-geoip #2646
Bump geoip2 from 2.16.1 to 3.0.1 in /modules/ingest-geoip #2646
Conversation
Bumps [geoip2](https://github.com/maxmind/GeoIP2-java) from 2.16.1 to 3.0.1. - [Release notes](https://github.com/maxmind/GeoIP2-java/releases) - [Changelog](https://github.com/maxmind/GeoIP2-java/blob/main/CHANGELOG.md) - [Commits](maxmind/GeoIP2-java@v2.16.1...v3.0.1) --- updated-dependencies: - dependency-name: com.maxmind.geoip2:geoip2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
nvm, precommit failures, will see what breaking changes are involved in bringing in a new major version.
|
Signed-off-by: Marc Handalian <handalm@amazon.com>
Precommit is failing because forbiddenApis was configured to ignore missing classes that are present. Signed-off-by: Marc Handalian <handalm@amazon.com>
Some valid |
Tests are failing bc of the change from long to int.
I'm thinking this is ok to include as a breaking change for 3.0 and change our API to return the long value directly. Thoughts? @nknize |
Yes, it's fine to refactor GeoIpProcessor asn variable to a Long instead of an Integer since that changed in the maxmind library. |
Signed-off-by: Marc Handalian <handalm@amazon.com>
Looks like an execution error not on a specific test, retrying. |
start gradle check |
Backporting to 2.x and 2.0, stop me if I am doing it wrong. |
* Bump geoip2 from 2.16.1 to 3.0.1 in /modules/ingest-geoip Bumps [geoip2](https://github.com/maxmind/GeoIP2-java) from 2.16.1 to 3.0.1. - [Release notes](https://github.com/maxmind/GeoIP2-java/releases) - [Changelog](https://github.com/maxmind/GeoIP2-java/blob/main/CHANGELOG.md) - [Commits](maxmind/GeoIP2-java@v2.16.1...v3.0.1) --- updated-dependencies: - dependency-name: com.maxmind.geoip2:geoip2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Fix breaking change with geoip2 version 3.0.1. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fix precommit failures caused by ignoreMissingClasses check. Precommit is failing because forbiddenApis was configured to ignore missing classes that are present. Signed-off-by: Marc Handalian <handalm@amazon.com> * Change asn in GeoIpProcessorTests from int to long. Signed-off-by: Marc Handalian <handalm@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Marc Handalian <handalm@amazon.com> (cherry picked from commit ce5c55d)
* Bump geoip2 from 2.16.1 to 3.0.1 in /modules/ingest-geoip Bumps [geoip2](https://github.com/maxmind/GeoIP2-java) from 2.16.1 to 3.0.1. - [Release notes](https://github.com/maxmind/GeoIP2-java/releases) - [Changelog](https://github.com/maxmind/GeoIP2-java/blob/main/CHANGELOG.md) - [Commits](maxmind/GeoIP2-java@v2.16.1...v3.0.1) --- updated-dependencies: - dependency-name: com.maxmind.geoip2:geoip2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Fix breaking change with geoip2 version 3.0.1. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fix precommit failures caused by ignoreMissingClasses check. Precommit is failing because forbiddenApis was configured to ignore missing classes that are present. Signed-off-by: Marc Handalian <handalm@amazon.com> * Change asn in GeoIpProcessorTests from int to long. Signed-off-by: Marc Handalian <handalm@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Marc Handalian <handalm@amazon.com> (cherry picked from commit ce5c55d)
) * Bump geoip2 from 2.16.1 to 3.0.1 in /modules/ingest-geoip Bumps [geoip2](https://github.com/maxmind/GeoIP2-java) from 2.16.1 to 3.0.1. - [Release notes](https://github.com/maxmind/GeoIP2-java/releases) - [Changelog](https://github.com/maxmind/GeoIP2-java/blob/main/CHANGELOG.md) - [Commits](maxmind/GeoIP2-java@v2.16.1...v3.0.1) --- updated-dependencies: - dependency-name: com.maxmind.geoip2:geoip2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Fix breaking change with geoip2 version 3.0.1. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fix precommit failures caused by ignoreMissingClasses check. Precommit is failing because forbiddenApis was configured to ignore missing classes that are present. Signed-off-by: Marc Handalian <handalm@amazon.com> * Change asn in GeoIpProcessorTests from int to long. Signed-off-by: Marc Handalian <handalm@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Marc Handalian <handalm@amazon.com> (cherry picked from commit ce5c55d) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) * Bump geoip2 from 2.16.1 to 3.0.1 in /modules/ingest-geoip Bumps [geoip2](https://github.com/maxmind/GeoIP2-java) from 2.16.1 to 3.0.1. - [Release notes](https://github.com/maxmind/GeoIP2-java/releases) - [Changelog](https://github.com/maxmind/GeoIP2-java/blob/main/CHANGELOG.md) - [Commits](maxmind/GeoIP2-java@v2.16.1...v3.0.1) --- updated-dependencies: - dependency-name: com.maxmind.geoip2:geoip2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Fix breaking change with geoip2 version 3.0.1. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fix precommit failures caused by ignoreMissingClasses check. Precommit is failing because forbiddenApis was configured to ignore missing classes that are present. Signed-off-by: Marc Handalian <handalm@amazon.com> * Change asn in GeoIpProcessorTests from int to long. Signed-off-by: Marc Handalian <handalm@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Marc Handalian <handalm@amazon.com> (cherry picked from commit ce5c55d) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps geoip2 from 2.16.1 to 3.0.1.
Release notes
Sourced from geoip2's releases.
Changelog
Sourced from geoip2's changelog.
Commits
ddcc4c4
[maven-release-plugin] prepare release v3.0.14339c1e
update version number in README.md2b291fb
Prepare for 3.0.16643f62
Update jackson-databind to 2.13.2.206fc64f
Merge pull request #306 from slunker/main29f257e
Merge pull request #307 from maxmind/dependabot/maven/com.fasterxml.jackson.c...973e842
Bump jackson-databind from 2.13.2 to 2.13.2.1fbb460f
Bump jackson-databind to 2.23.2.126e2f25
Merge pull request #305 from maxmind/dependabot/maven/org.codehaus.mojo-versi...1e61c74
Bump versions-maven-plugin from 2.9.0 to 2.10.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)