-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/extensions]Enforce type safety for RegisterTransportActionsRequest #4796
[Feature/extensions]Enforce type safety for RegisterTransportActionsRequest #4796
Conversation
@mloufra Can you edit your title to add |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## feature/extensions #4796 +/- ##
========================================================
+ Coverage 70.52% 70.62% +0.09%
+ Complexity 57898 57799 -99
========================================================
Files 4708 4706 -2
Lines 278528 277836 -692
Branches 40661 40389 -272
========================================================
- Hits 196420 196208 -212
+ Misses 65740 65354 -386
+ Partials 16368 16274 -94
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally put the feature/extensions tag at the beginning of the title. A more descriptive title than "Compiler Warning" might be helpful, such as "Enforce type safety for RegisterTransportActionsRequest".
Also per CI checks you need a change log.
|
||
public RegisterTransportActionsRequest(String uniqueId, Map<String, Class> transportActions) { | ||
public RegisterTransportActionsRequest(String uniqueId, Map<String, Class<?>> transportActions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is called from the SDK with this line:
new RegisterTransportActionsRequest(uniqueId, transportActions),
See comment here for narrower types needed.
Gradle Check (Jenkins) Run Completed with:
|
@mloufra you need to make the changes in test files as well
|
Thanks for the reminder, I'm trying to fix this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here look good, per other comment need to also update test files.
Signed-off-by: mloufra <mloufra@amazon.com>
60ad8b9
to
8750132
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: mloufra <mloufra@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: mloufra mloufra@amazon.com
Description
Add unbounded wildcard for RegisterTransportActionsRequest constructor to clean up compiler warning
Equivalent PR on OpenSearch-sdk-java: opensearch-project/opensearch-sdk-java#195
Issues Resolved
opensearch-project/opensearch-sdk-java#130
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.