-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler warning #195
Merged
saratvemulapalli
merged 2 commits into
opensearch-project:main
from
mloufra:compilerwarning
Oct 21, 2022
Merged
Compiler warning #195
saratvemulapalli
merged 2 commits into
opensearch-project:main
from
mloufra:compilerwarning
Oct 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested changes
Oct 14, 2022
@mloufra can you rebase your branch with latest main and push the changes? |
Signed-off-by: mloufra <mloufra@amazon.com>
Signed-off-by: mloufra <mloufra@amazon.com>
mloufra
force-pushed
the
compilerwarning
branch
from
October 17, 2022 22:02
9e98854
to
209ff63
Compare
dbwiddis
approved these changes
Oct 18, 2022
saratvemulapalli
approved these changes
Oct 18, 2022
Awaiting merging of companion PR |
Codecov Report
@@ Coverage Diff @@
## main #195 +/- ##
=========================================
Coverage 66.45% 66.45%
Complexity 101 101
=========================================
Files 25 25
Lines 480 480
Branches 18 18
=========================================
Hits 319 319
Misses 148 148
Partials 13 13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* clean up compiler warning Signed-off-by: mloufra <mloufra@amazon.com> * add type for transportAction Signed-off-by: mloufra <mloufra@amazon.com> Signed-off-by: mloufra <mloufra@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mloufra mloufra@amazon.com
Description
Add Add unbounded wildcard for
transportActions
inTransportActions.java
to clean up compiler warning.Equivalent PR on OpenSearch: opensearch-project/OpenSearch#4796
Issues Resolved
#130
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.