Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make searchable snapshot indexes read-only but allow deletion (#4764) #4958

Merged

Conversation

Vishalks
Copy link
Contributor

@Vishalks Vishalks commented Oct 27, 2022

This commit adds a new cluster block that is added by default to all searchable snapshot indexes to block writes and metadata changes.

Signed-off-by: Vishal Sarda vsarda@amazon.com
(cherry picked from commit c4fc1bc)
Signed-off-by: Vishal Sarda vsarda@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…arch-project#4764)

This commit adds a new cluster block that is added by default to all searchable
snapshot indexes to block writes and metadata changes.

Signed-off-by: Vishal Sarda <vsarda@amazon.com>
(cherry picked from commit c4fc1bc)
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
@Vishalks Vishalks requested review from a team and reta as code owners October 27, 2022 18:40
CHANGELOG.md Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #4958 (c4fc1bc) into 2.x (5f3dc34) will increase coverage by 0.18%.
The diff coverage is 55.46%.

❗ Current head c4fc1bc differs from pull request most recent head 4c1c0e9. Consider uploading reports for the commit 4c1c0e9 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #4958      +/-   ##
============================================
+ Coverage     70.70%   70.88%   +0.18%     
- Complexity    57668    57959     +291     
============================================
  Files          4620     4688      +68     
  Lines        276202   276898     +696     
  Branches      40420    40299     -121     
============================================
+ Hits         195294   196291     +997     
+ Misses        64637    64323     -314     
- Partials      16271    16284      +13     
Impacted Files Coverage Δ
...ark/time/NanoTimeVsCurrentTimeMillisBenchmark.java 0.00% <0.00%> (ø)
...nsearch/gradle/precommit/LicenseHeadersTask.groovy 0.00% <ø> (ø)
.../java/org/opensearch/gradle/JdkDownloadPlugin.java 37.36% <0.00%> (ø)
...org/opensearch/gradle/RepositoriesSetupPlugin.java 38.63% <0.00%> (ø)
...ensearch/gradle/precommit/FilePermissionsTask.java 78.78% <ø> (ø)
...search/gradle/precommit/ForbiddenPatternsTask.java 88.40% <ø> (ø)
...g/opensearch/gradle/precommit/LoggerUsageTask.java 0.00% <ø> (ø)
...ensearch/gradle/precommit/ThirdPartyAuditTask.java 0.00% <0.00%> (ø)
...ensearch/gradle/tar/SymbolicLinkPreservingTar.java 0.00% <0.00%> (ø)
...a/org/opensearch/gradle/test/DistroTestPlugin.java 0.00% <ø> (ø)
... and 978 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Vishal Sarda <vsarda@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants