Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Added support for feature flags in opensearch.yml (#4959) #5941

Merged
merged 1 commit into from
Jan 19, 2023
Merged

[Backport 2.x] Added support for feature flags in opensearch.yml (#4959) #5941

merged 1 commit into from
Jan 19, 2023

Conversation

andrross
Copy link
Member

Backport 241bd42 from #4958

@ntantri @andrross
Added support for feature flags in opensearch.yml (opensearch-project…
650e47d 
…#4959)

This change introduces a static store "settings"
in FeatureFlags.java file to enable isEnabled method to
fetch flag settings defined in opensearch.yml.

Signed-off-by: Nagaraj Tantri <nagarajtantri@gmail.com>

Signed-off-by: Nagaraj Tantri <nagarajtantri@gmail.com>
@andrross andrross mentioned this pull request Jan 19, 2023
Closed
6 tasks
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal kotwanikunal merged commit cdb2b26 into opensearch-project:2.x Jan 19, 2023
@andrross andrross deleted the backport-4959 branch January 19, 2023 22:36
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
@andrross @ntantri @kotwanikunal
Added support for feature flags in opensearch.yml (#4959) (#5941)
5aa95e3 
This change introduces a static store "settings"
in FeatureFlags.java file to enable isEnabled method to
fetch flag settings defined in opensearch.yml.

Signed-off-by: Nagaraj Tantri <nagarajtantri@gmail.com>

Signed-off-by: Nagaraj Tantri <nagarajtantri@gmail.com>

Signed-off-by: Nagaraj Tantri <nagarajtantri@gmail.com>
Co-authored-by: Nagaraj Tantri <nagarajtantri@gmail.com>
@dreamer-89 dreamer-89 mentioned this pull request Mar 23, 2023
Merged
6 tasks
@dreamer-89 dreamer-89 mentioned this pull request Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@mch2 mch2 mch2 approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@adnapibar adnapibar Awaiting requested review from adnapibar

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@xuezhou25 xuezhou25 Awaiting requested review from xuezhou25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrross @mch2 @kotwanikunal @ntantri