Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump spock-core from 2.1-groovy-3.0 to 2.3-groovy-3.0 #5315

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 21, 2022

Bumps spock-core from 2.1-groovy-3.0 to 2.3-groovy-4.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from a team and reta as code owners November 21, 2022 13:11
@dependabot dependabot bot added dependabot PRs with auto version bumps from dependabot dependencies Pull requests that update a dependency file labels Nov 21, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

dependabot bot and others added 3 commits November 21, 2022 12:28
Bumps spock-core from 2.1-groovy-3.0 to 2.3-groovy-4.0.

---
updated-dependencies:
- dependency-name: org.spockframework:spock-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…tead of Groovy 4.0

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kartg kartg changed the title Bump spock-core from 2.1-groovy-3.0 to 2.3-groovy-4.0 Bump spock-core from 2.1-groovy-3.0 to 2.3-groovy-3.0 Nov 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #5315 (c40c276) into main (7dc137f) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5315      +/-   ##
============================================
- Coverage     71.03%   71.00%   -0.04%     
+ Complexity    58129    58125       -4     
============================================
  Files          4704     4704              
  Lines        277266   277266              
  Branches      40147    40147              
============================================
- Hits         196957   196863      -94     
- Misses        64129    64341     +212     
+ Partials      16180    16062     -118     
Impacted Files Coverage Δ
...adonly/AddIndexBlockClusterStateUpdateRequest.java 0.00% <0.00%> (-75.00%) ⬇️
...pensearch/client/cluster/RemoteConnectionInfo.java 0.00% <0.00%> (-68.30%) ⬇️
...a/org/opensearch/client/cluster/ProxyModeInfo.java 0.00% <0.00%> (-55.00%) ⬇️
.../java/org/opensearch/node/NodeClosedException.java 50.00% <0.00%> (-50.00%) ⬇️
.../action/admin/indices/flush/ShardFlushRequest.java 50.00% <0.00%> (-50.00%) ⬇️
...cluster/coordination/PendingClusterStateStats.java 20.00% <0.00%> (-48.00%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
.../java/org/opensearch/search/dfs/AggregatedDfs.java 54.83% <0.00%> (-41.94%) ⬇️
...readonly/TransportVerifyShardIndexBlockAction.java 9.75% <0.00%> (-41.47%) ⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java 60.00% <0.00%> (-40.00%) ⬇️
... and 496 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kartg kartg force-pushed the dependabot/gradle/org.spockframework-spock-core-2.3-groovy-4.0 branch from c40c276 to 4db69f3 Compare November 21, 2022 20:38
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kartg
Copy link
Member

kartg commented Nov 21, 2022

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=166FDD2EC2FB795E -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-UY -Dtests.timezone=Australia/Eucla -Druntime.java=19

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([166FDD2EC2FB795E:111908E5F97D0F03]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

I was unable to reproduce the failure locally, so i'll refire gradle check

- Bumps `maxmind-db` from 2.0.0 to 2.1.0 ([#5236](https://github.com/opensearch-project/OpenSearch/pull/5236))
- Bumps `azure-core` from 1.33.0 to 1.34.0 ([#5235](https://github.com/opensearch-project/OpenSearch/pull/5235))
- Bumps `azure-core-http-netty` from 1.12.4 to 1.12.7 ([#5235](https://github.com/opensearch-project/OpenSearch/pull/5235))
- Bumps `spock-core` from from 2.1-groovy-3.0 to 2.3-groovy-3.0 ([#5315](https://github.com/opensearch-project/OpenSearch/pull/5315))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for collecting these from the other PRs!

@dblock
Copy link
Member

dblock commented Nov 21, 2022

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=166FDD2EC2FB795E -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-UY -Dtests.timezone=Australia/Eucla -Druntime.java=19

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([166FDD2EC2FB795E:111908E5F97D0F03]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

I was unable to reproduce the failure locally, so i'll refire gradle check

It's #1703.

@kartg
Copy link
Member

kartg commented Nov 21, 2022

@dblock ouch, that's been open for nearly a year now 😱

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kartg kartg merged commit 508ceaf into main Nov 21, 2022
@dependabot dependabot bot deleted the dependabot/gradle/org.spockframework-spock-core-2.3-groovy-4.0 branch November 21, 2022 22:29
kartg added a commit to kartg/OpenSearch that referenced this pull request Jun 16, 2023
Manual backport of opensearch-project#5315

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
kartg added a commit that referenced this pull request Jun 16, 2023
* Bump spock-core from 2.1-groovy-3.0 to 2.3-groovy-3.0

Manual backport of #5315

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

* Added CHANGELOG entry

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

---------

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…ject#8122)

* Bump spock-core from 2.1-groovy-3.0 to 2.3-groovy-3.0

Manual backport of opensearch-project#5315

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

* Added CHANGELOG entry

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

---------

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependabot PRs with auto version bumps from dependabot dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants