Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump spock-core from 2.1-groovy-3.0 to 2.3-groovy-3.0 #8122

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

kartg
Copy link
Member

@kartg kartg commented Jun 16, 2023

Description

Manual backport of #5315 to bump the minor version of spock-core

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Manual backport of opensearch-project#5315

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #8122 (00cd200) into 2.x (59a62e7) will increase coverage by 0.05%.
The diff coverage is 84.61%.

@@             Coverage Diff              @@
##                2.x    #8122      +/-   ##
============================================
+ Coverage     70.63%   70.69%   +0.05%     
- Complexity    56771    56788      +17     
============================================
  Files          4703     4703              
  Lines        269046   269056      +10     
  Branches      39768    39770       +2     
============================================
+ Hits         190048   190199     +151     
+ Misses        62694    62474     -220     
- Partials      16304    16383      +79     
Impacted Files Coverage Δ
.../org/opensearch/common/settings/SecureSetting.java 74.62% <84.61%> (+9.71%) ⬆️

... and 449 files with indirect coverage changes

@kartg kartg merged commit 6c8d97c into opensearch-project:2.x Jun 16, 2023
11 checks passed
@kartg kartg deleted the spock-core-update-2x branch June 20, 2023 19:58
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…ject#8122)

* Bump spock-core from 2.1-groovy-3.0 to 2.3-groovy-3.0

Manual backport of opensearch-project#5315

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

* Added CHANGELOG entry

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

---------

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants