-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of default replica count change #5610
Merged
Bukhtawar
merged 23 commits into
opensearch-project:main
from
Arpit-Bandejiya:default_config
Jan 6, 2023
Merged
Add support of default replica count change #5610
Bukhtawar
merged 23 commits into
opensearch-project:main
from
Arpit-Bandejiya:default_config
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Arpit-Bandejiya
force-pushed
the
default_config
branch
from
December 27, 2022 06:53
c3bd1c6
to
10e54d9
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Arpit-Bandejiya
force-pushed
the
default_config
branch
from
December 27, 2022 10:09
10e54d9
to
f563943
Compare
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Arpit-Bandejiya
changed the title
Add default config change setting for replica count
Add support of default replica count change using total awareness attribute
Dec 27, 2022
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Arpit-Bandejiya
force-pushed
the
default_config
branch
from
December 27, 2022 12:30
b066fa5
to
d28ae15
Compare
Arpit-Bandejiya
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
setiah,
kartg,
kotwanikunal,
mch2 and
nknize
as code owners
December 27, 2022 12:34
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Arpit-Bandejiya
force-pushed
the
default_config
branch
from
January 5, 2023 12:13
fcb75f5
to
aa541ad
Compare
Arpit-Bandejiya
changed the title
Add support of default replica count change using total awareness attribute
Add support of default replica count change
Jan 5, 2023
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Arpit-Bandejiya
force-pushed
the
default_config
branch
from
January 5, 2023 18:20
aa541ad
to
3a1afc0
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
approved these changes
Jan 6, 2023
Please rebase from main . It should fix the test failures . |
Arpit-Bandejiya
force-pushed
the
default_config
branch
from
January 6, 2023 05:11
9790f98
to
4fa42d8
Compare
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5610-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 12782f770a37eeebe39659bd39c4d528826dba2d
# Push it to GitHub
git push --set-upstream origin backport/backport-5610-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
Arpit-Bandejiya
added a commit
to Arpit-Bandejiya/OpenSearch
that referenced
this pull request
Jan 6, 2023
* Add default replica count config settings Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Arpit-Bandejiya
added a commit
to Arpit-Bandejiya/OpenSearch
that referenced
this pull request
Jan 6, 2023
* Add default replica count config settings Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Bukhtawar
pushed a commit
that referenced
this pull request
Jan 6, 2023
6 tasks
4 tasks
kotwanikunal
pushed a commit
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arpit Bandejiya abandeji@amazon.com
Description
Introduces a new cluster setting
default_number_of_replicas
. The setting set the default replica count to 1 by default. Once set, the default count fornumber_of_replicas
will change based on the value.Issues Resolved
Solves issue 5457
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.