Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of default replica count change #5610

Merged
merged 23 commits into from
Jan 6, 2023

Conversation

Arpit-Bandejiya
Copy link
Contributor

@Arpit-Bandejiya Arpit-Bandejiya commented Dec 21, 2022

Signed-off-by: Arpit Bandejiya abandeji@amazon.com

Description

Introduces a new cluster setting default_number_of_replicas. The setting set the default replica count to 1 by default. Once set, the default count for number_of_replicas will change based on the value.

Issues Resolved

Solves issue 5457

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@Arpit-Bandejiya Arpit-Bandejiya changed the title Add default config change setting for replica count Add support of default replica count change using total awareness attribute Dec 27, 2022
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Gradle Check (Jenkins) Run Completed with:

@Arpit-Bandejiya Arpit-Bandejiya changed the title Add support of default replica count change using total awareness attribute Add support of default replica count change Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Gradle Check (Jenkins) Run Completed with:

@gbbafna
Copy link
Collaborator

gbbafna commented Jan 6, 2023

Please rebase from main . It should fix the test failures .

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Gradle Check (Jenkins) Run Completed with:

@Bukhtawar Bukhtawar merged commit 12782f7 into opensearch-project:main Jan 6, 2023
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jan 6, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5610-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 12782f770a37eeebe39659bd39c4d528826dba2d
# Push it to GitHub
git push --set-upstream origin backport/backport-5610-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5610-to-2.x.

Arpit-Bandejiya added a commit to Arpit-Bandejiya/OpenSearch that referenced this pull request Jan 6, 2023
* Add default replica count config settings

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Arpit-Bandejiya added a commit to Arpit-Bandejiya/OpenSearch that referenced this pull request Jan 6, 2023
* Add default replica count config settings

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Bukhtawar pushed a commit that referenced this pull request Jan 6, 2023
*[Backport 2.x] Add default replica count config settings

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
*[Backport 2.x] Add default replica count config settings

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants