Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TransportReplicationActionTests #5737

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Fix TransportReplicationActionTests #5737

merged 1 commit into from
Jan 6, 2023

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Jan 6, 2023 •
edited
Loading

Signed-off-by: Suraj Singh surajrider@gmail.com

Description

Existing gradle checks failures(example), are happening due to recent change from PR #5610, which overrides older ClusterService state, removing previously added DiscoveryNodes nodes here. The removed DiscoverNodes were used in tests. This change adds existing discovery nodes back into cluster state while building the cluster state.

Issues Resolved

NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89
Fix TransportReplicationActionTests
91cf969 
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      3 org.opensearch.indices.replication.SegmentReplicationIT.testPrimaryStopped_ReplicaPromoted
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testUpdateOperations
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocationWithSegRepFailure

@dreamer-89 dreamer-89 mentioned this pull request Jan 6, 2023
Merged
6 tasks
@mch2 mch2 merged commit c90a34b into opensearch-project:main Jan 6, 2023
@dreamer-89 dreamer-89 mentioned this pull request Jan 6, 2023
Merged
6 tasks
@andrross andrross added backport 2.x Backport to 2.x branch backport 2.5 labels Jan 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
@github-actions
Fix TransportReplicationActionTests (#5737)
5a20117 
Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit c90a34b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 10, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
@github-actions
Fix TransportReplicationActionTests (#5737)
0470a4e 
Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit c90a34b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 10, 2023
Merged
@andrross andrross mentioned this pull request Jan 10, 2023
Closed
andrross pushed a commit that referenced this pull request Jan 10, 2023
@opensearch-trigger-bot @github-actions
Fix TransportReplicationActionTests (#5737) (#5807)
15a1c0e 
Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit c90a34b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@andrross andrross mentioned this pull request Jan 10, 2023
Closed
andrross pushed a commit that referenced this pull request Jan 11, 2023
@github-actions @andrross
Fix TransportReplicationActionTests (#5737)
fb36ca7 
Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit c90a34b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Jan 11, 2023
@opensearch-trigger-bot @github-actions
Fix TransportReplicationActionTests (#5737) (#5806)
6df30e8 
Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit c90a34b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
@opensearch-trigger-bot @github-actions @kotwanikunal
Fix TransportReplicationActionTests (#5737) (#5806)
fad9b16 
Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit c90a34b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@adnapibar adnapibar Awaiting requested review from adnapibar

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@xuezhou25 xuezhou25 Awaiting requested review from xuezhou25

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.5 skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamer-89 @mch2 @andrross