Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions] Only store names of extension transport actions #6545

Merged

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Mar 6, 2023

Companion PR: opensearch-project/opensearch-sdk-java#524
(PRs must be merged together, this one first.)

Description

o.o.extensions.RegisterTransportActionsRequest was incorrectly attempting to store a map with a compiled class available only to the SDK and not to OpenSearch.

This PR changes the request to track only the set of action names (exactly equivalent to the .keySet() of the prior map implementation), which was all that was being used by the handler anyway.

The SDK will maintain a map of name to actual compiled/executable action.

Issues Resolved

SDK #484

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
    - [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog) (No change log, bug fix to prerelease feature.)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Daniel Widdis <widdis@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Daniel Widdis <widdis@gmail.com>
@dbwiddis dbwiddis force-pushed the getactions-registration branch from ffd69d2 to dde5764 Compare March 6, 2023 05:58
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Daniel Widdis <widdis@gmail.com>
@dbwiddis dbwiddis force-pushed the getactions-registration branch from a7aa4f2 to 985e11a Compare March 6, 2023 15:20
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationAllocationIT.testAllocationWithDisruption
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@saratvemulapalli saratvemulapalli added extensions backport 2.x Backport to 2.x branch labels Mar 6, 2023
@saratvemulapalli saratvemulapalli merged commit 84cec8e into opensearch-project:main Mar 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
* Only store names of extension transport actions

Signed-off-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit 84cec8e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19 pushed a commit that referenced this pull request Mar 7, 2023
…6556)

* Only store names of extension transport actions


(cherry picked from commit 84cec8e)

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mingshl pushed a commit to mingshl/OpenSearch-Mingshl that referenced this pull request Mar 24, 2023
…rch-project#6545)

* Only store names of extension transport actions

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
@dbwiddis dbwiddis deleted the getactions-registration branch April 4, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants