-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] Only store names of extension transport actions #6545
Merged
saratvemulapalli
merged 3 commits into
opensearch-project:main
from
dbwiddis:getactions-registration
Mar 6, 2023
Merged
[Extensions] Only store names of extension transport actions #6545
saratvemulapalli
merged 3 commits into
opensearch-project:main
from
dbwiddis:getactions-registration
Mar 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Daniel Widdis <widdis@gmail.com>
ffd69d2
to
dde5764
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Daniel Widdis <widdis@gmail.com>
a7aa4f2
to
985e11a
Compare
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
approved these changes
Mar 6, 2023
ryanbogan
approved these changes
Mar 6, 2023
saratvemulapalli
approved these changes
Mar 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 6, 2023
* Only store names of extension transport actions Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 84cec8e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Mar 7, 2023
…6556) * Only store names of extension transport actions (cherry picked from commit 84cec8e) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mingshl
pushed a commit
to mingshl/OpenSearch-Mingshl
that referenced
this pull request
Mar 24, 2023
…rch-project#6545) * Only store names of extension transport actions Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: opensearch-project/opensearch-sdk-java#524
(PRs must be merged together, this one first.)
Description
o.o.extensions.RegisterTransportActionsRequest
was incorrectly attempting to store a map with a compiled class available only to the SDK and not to OpenSearch.This PR changes the request to track only the set of action names (exactly equivalent to the
.keySet()
of the prior map implementation), which was all that was being used by the handler anyway.The SDK will maintain a map of name to actual compiled/executable action.
Issues Resolved
SDK #484
Check List
- [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)(No change log, bug fix to prerelease feature.)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.