Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added @dbwiddis to OpenSearch maintainers #7665

Merged
merged 1 commit into from
May 23, 2023

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented May 22, 2023

Description

I nominated Dan Widdis (@dbwiddis) to be a co-maintainer for Opensearch through our nomination process. The maintainers have agreed, and Dan has kindly accepted.

Dan is already a maintainer of opensearch-sdk-java and working actively on Extensibility. Dan has authored several PRs on OpenSearch repo. Few of them got merged to feature/extensions branch and then later to main.

  1. Add DynamicActionRegistry to ActionModule
  2. Update ExtensionRestResponse to handle RestRequest object
  3. Only store names of extension transport actions
  4. Handle Deprecated and Replaced Routes in Extension Rest Handlers
  5. getSettings extension point support

Dan is active almost daily in the project, thoughtfully reviewing and commenting on pull requests (example). He has also closed 19 issues on core repo.

Few other contributions done by Dan:

  1. Avoid negative memory result in IndicesQueryCache stats calculation
  2. Don't register destructiveDistroTest.docker twice
  3. Remove deprecated org.gradle.util.DistributionLocator usage
  4. Include Windows OS in Bootstrap initializeNatives() check for definitelyRunningAsRoot()

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@owaiskazi19 owaiskazi19 marked this pull request as draft May 22, 2023 17:54
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Collaborator

nknize commented May 22, 2023

> Task :server:jarHell FAILED
| Output for C:\hostedtoolcache\windows\Java_Adopt_jdk\11.0.19-7\x64\bin\java.exe:#
# There is insufficient memory for the Java Runtime Environment to continue.

Sheesh! Brittle! Can't even pass a maintainers update. 🤦🏻‍♂️

Re-firing

@nknize
Copy link
Collaborator

nknize commented May 22, 2023

DiskThresholdDeciderIT strikes again... Love it when we're trolled by flakes.

./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled" -Dtests.seed=62BA04CB1F0111FC -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=pl -Dtests.timezone=Indian/Chagos -Druntime.java=19

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member

dblock commented May 23, 2023

Do we need to add @dbwiddis to CODEOWNERS too?

I adjusted permissions.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #7665 (2a08c9d) into main (b4b3724) will increase coverage by 70.82%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #7665       +/-   ##
===========================================
+ Coverage        0   70.82%   +70.82%     
- Complexity      0    56158    +56158     
===========================================
  Files           0     4680     +4680     
  Lines           0   266081   +266081     
  Branches        0    39067    +39067     
===========================================
+ Hits            0   188439   +188439     
- Misses          0    61684    +61684     
- Partials        0    15958    +15958     

see 4680 files with indirect coverage changes

@dblock dblock marked this pull request as ready for review May 23, 2023 21:22
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

@xuezhou25 please speak reach out if you want your maintainer permissions restored - that was automatically adjusted when leaving the org

@dblock dblock merged commit f640c40 into opensearch-project:main May 23, 2023
@dblock dblock added backport 2.x Backport to 2.x branch backport 1.x labels May 23, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-7665-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f640c40becb8cf18e61442fa205ad77d02d5b283
# Push it to GitHub
git push --set-upstream origin backport/backport-7665-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-7665-to-1.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7665-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f640c40becb8cf18e61442fa205ad77d02d5b283
# Push it to GitHub
git push --set-upstream origin backport/backport-7665-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7665-to-2.x.

owaiskazi19 added a commit to owaiskazi19/OpenSearch that referenced this pull request May 23, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19 added a commit to owaiskazi19/OpenSearch that referenced this pull request May 23, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19 added a commit to owaiskazi19/OpenSearch that referenced this pull request May 23, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
reta pushed a commit that referenced this pull request May 24, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
dblock pushed a commit to dblock/OpenSearch that referenced this pull request May 25, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
suranjay pushed a commit to suranjay/OpenSearch that referenced this pull request May 29, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
stephen-crawford pushed a commit to stephen-crawford/OpenSearch that referenced this pull request May 31, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants