-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added @dbwiddis to OpenSearch maintainers #7665
Conversation
9af7715
to
a89e31e
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Sheesh! Brittle! Can't even pass a maintainers update. 🤦🏻♂️ Re-firing |
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Do we need to add @dbwiddis to CODEOWNERS too? I adjusted permissions. |
a89e31e
to
496fe13
Compare
Gradle Check (Jenkins) Run Completed with:
|
496fe13
to
d56ee9a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
d56ee9a
to
2a08c9d
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7665 +/- ##
===========================================
+ Coverage 0 70.82% +70.82%
- Complexity 0 56158 +56158
===========================================
Files 0 4680 +4680
Lines 0 266081 +266081
Branches 0 39067 +39067
===========================================
+ Hits 0 188439 +188439
- Misses 0 61684 +61684
- Partials 0 15958 +15958 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good.
@xuezhou25 please speak reach out if you want your maintainer permissions restored - that was automatically adjusted when leaving the org
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-7665-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f640c40becb8cf18e61442fa205ad77d02d5b283
# Push it to GitHub
git push --set-upstream origin backport/backport-7665-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7665-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f640c40becb8cf18e61442fa205ad77d02d5b283
# Push it to GitHub
git push --set-upstream origin backport/backport-7665-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
I nominated Dan Widdis (@dbwiddis) to be a co-maintainer for Opensearch through our nomination process. The maintainers have agreed, and Dan has kindly accepted.
Dan is already a maintainer of opensearch-sdk-java and working actively on Extensibility. Dan has authored several PRs on OpenSearch repo. Few of them got merged to
feature/extensions
branch and then later tomain
.Dan is active almost daily in the project, thoughtfully reviewing and commenting on pull requests (example). He has also closed 19 issues on core repo.
Few other contributions done by Dan:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.