[Extensions] Update ExtensionRestResponse to handle RestRequest object #6874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
This was referenced Mar 29, 2023
ryanbogan
approved these changes
Mar 30, 2023
owaiskazi19
approved these changes
Mar 30, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit cdab7f2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
tlfeng
pushed a commit
that referenced
this pull request
Apr 3, 2023
) Extensions do not use all the internal components of a `RestRequest` and initial implementation double-purposed the `ExtensionsRestRequest` object used in transport as the object that Extensions would need to handle. However, increasing use of the methods on this object are ending up duplicating a lot of code. It makes a lot more sense to just recreate a `RestRequest` object from the parameters passed in this request. (cherry picked from commit cdab7f2) Signed-off-by: Daniel Widdis <widdis@gmail.com>
mitrofmep
pushed a commit
to mitrofmep/OpenSearch
that referenced
this pull request
Apr 5, 2023
…-project#6874) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Valentin Mitrofanov <mitrofmep@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PRs (this one must be merged first of three):
Description
Extensions do not use all the internal components of a
RestRequestand initial implementation double-purposed theExtensionsRestRequestobject used in transport as the object that Extensions would need to handle. However, increasing use of the methods on this object are ending up duplicating a lot of code. It makes a lot more sense to just recreate aRestRequestobject from the parameters passed in this request.While this is marked api, it is only used behind feature-flagged code and will not break any BWC.
Issues Resolved
Part of SDK #431.
Check List
Commit changes are listed out in CHANGELOG.md file (See: Changelog)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.