-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] Handle Deprecated and Replaced Routes in Extension Rest Handlers #7064
Conversation
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #7064 +/- ##
============================================
- Coverage 70.74% 70.61% -0.14%
+ Complexity 59329 59281 -48
============================================
Files 4825 4825
Lines 284369 284390 +21
Branches 41021 41024 +3
============================================
- Hits 201177 200808 -369
- Misses 66665 67059 +394
+ Partials 16527 16523 -4
... and 503 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
LGTM |
Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit ec92b4b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…nsearch-project#7064) Signed-off-by: Daniel Widdis <widdis@gmail.com>
Companion PR on SDK: opensearch-project/opensearch-sdk-java#666
Description
Adds the ability to handle Deprecated and Replaced Routes to the ExtensionRestHandler. This will permit (nearly) identical syntax for plugin migration, and provide backwards compatibility to extension users.
The OpenSearch integration adds a new list to the existing registration request. In addition to the method and path sent for routes, deprecated routes have a deprecationMessage included. This is included in a separate list where the message immediately follows the method/path.
Issues Resolved
Fixes SDK #665
Check List
Commit changes are listed out in CHANGELOG.md file (See: Changelog)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.