Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] SegRep with Remote: Update components of segrep backpressure to support remote store. (#8020) #8066

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Jun 14, 2023

  • SegRep with Remote: Update components of segrep backpressure to support remote store.

Backporting #8020

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize nknize changed the title SegRep with Remote: Update components of segrep backpressure to suppo… SegRep with Remote: Update components of segrep backpressure to support remote store. (#8020) Jun 14, 2023
@mch2 mch2 changed the title SegRep with Remote: Update components of segrep backpressure to support remote store. (#8020) [Backport 2.x] SegRep with Remote: Update components of segrep backpressure to support remote store. (#8020) Jun 14, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

opensearch-project#8020)

* SegRep with Remote: Update components of segrep backpressure to support remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Adding tests

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ankit Kala <ankikala@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
      1 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.testSnapshotAndRestore
      1 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.testReadNonExistingPath
      1 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.testMultipleSnapshotAndRollback
      1 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.testEnforcedCooldownPeriod
      1 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.classMethod

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #8066 (aa16069) into 2.x (bcd9962) will decrease coverage by 0.05%.
The diff coverage is 88.33%.

@@             Coverage Diff              @@
##                2.x    #8066      +/-   ##
============================================
- Coverage     70.73%   70.68%   -0.05%     
- Complexity    56833    56846      +13     
============================================
  Files          4702     4703       +1     
  Lines        268987   269041      +54     
  Branches      39767    39768       +1     
============================================
- Hits         190268   190176      -92     
- Misses        62394    62517     +123     
- Partials      16325    16348      +23     
Impacted Files Coverage Δ
...ndices/replication/OngoingSegmentReplications.java 92.50% <ø> (-0.28%) ⬇️
...s/replication/SegmentReplicationSourceHandler.java 92.00% <ø> (-0.11%) ⬇️
server/src/main/java/org/opensearch/node/Node.java 85.99% <ø> (ø)
...s/replication/SegmentReplicationSourceService.java 89.74% <80.00%> (-1.44%) ⬇️
...s/replication/SegmentReplicationTargetService.java 68.04% <83.87%> (+6.69%) ⬆️
...org/opensearch/index/seqno/ReplicationTracker.java 68.18% <100.00%> (-0.01%) ⬇️
...es/replication/UpdateVisibleCheckpointRequest.java 100.00% <100.00%> (ø)

... and 454 files with indirect coverage changes

Signed-off-by: Ankit Kala <ankikala@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPressureServiceStats

@shwetathareja shwetathareja merged commit 59a62e7 into opensearch-project:2.x Jun 16, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…essure to support remote store. (opensearch-project#8020) (opensearch-project#8066)

* SegRep with Remote: Update components of segrep backpressure to suppo… (opensearch-project#8020)

* SegRep with Remote: Update components of segrep backpressure to support remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants