Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SegRep with Remote: Update components of segrep backpressure to suppo… #8020

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Jun 12, 2023

…rt remote store.

Description

Update components of segrep backpressure to support remote store.

Related Issues

#7410

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…rt remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.indices.replication.SegmentReplicationIT.testReplicationPostDeleteAndForceMerge

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #8020 (03af23f) into main (5c32256) will increase coverage by 0.08%.
The diff coverage is 88.33%.

@@             Coverage Diff              @@
##               main    #8020      +/-   ##
============================================
+ Coverage     70.88%   70.96%   +0.08%     
- Complexity    56561    56605      +44     
============================================
  Files          4719     4720       +1     
  Lines        267446   267500      +54     
  Branches      39210    39211       +1     
============================================
+ Hits         189582   189841     +259     
+ Misses        61873    61639     -234     
- Partials      15991    16020      +29     
Impacted Files Coverage Δ
...ndices/replication/OngoingSegmentReplications.java 92.50% <ø> (-0.28%) ⬇️
...s/replication/SegmentReplicationSourceHandler.java 92.00% <ø> (-0.11%) ⬇️
server/src/main/java/org/opensearch/node/Node.java 85.85% <ø> (ø)
...s/replication/SegmentReplicationSourceService.java 89.74% <80.00%> (-1.44%) ⬇️
...s/replication/SegmentReplicationTargetService.java 68.04% <83.87%> (+6.69%) ⬆️
...org/opensearch/index/seqno/ReplicationTracker.java 68.83% <100.00%> (+0.13%) ⬆️
...es/replication/UpdateVisibleCheckpointRequest.java 100.00% <100.00%> (ø)

... and 456 files with indirect coverage changes

Signed-off-by: Ankit Kala <ankikala@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ankit Kala <ankikala@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

@mch2 mch2 merged commit d15ad5e into opensearch-project:main Jun 14, 2023
@mch2 mch2 added the backport 2.x Backport to 2.x branch label Jun 14, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8020-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d15ad5efd12073460fcbd2791bf3b1ee845cb2fc
# Push it to GitHub
git push --set-upstream origin backport/backport-8020-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8020-to-2.x.

ankitkala added a commit to ankitkala/OpenSearch that referenced this pull request Jun 14, 2023
opensearch-project#8020)

* SegRep with Remote: Update components of segrep backpressure to support remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Adding tests

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 15, 2023
opensearch-project#8020)

* SegRep with Remote: Update components of segrep backpressure to support remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Adding tests

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
ankitkala added a commit to ankitkala/OpenSearch that referenced this pull request Jun 15, 2023
opensearch-project#8020)

* SegRep with Remote: Update components of segrep backpressure to support remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Adding tests

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
shwetathareja pushed a commit that referenced this pull request Jun 16, 2023
…essure to support remote store. (#8020) (#8066)

* SegRep with Remote: Update components of segrep backpressure to suppo… (#8020)

* SegRep with Remote: Update components of segrep backpressure to support remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>
ankitkala added a commit to linuxpi/OpenSearch that referenced this pull request Jun 20, 2023
opensearch-project#8020)

* SegRep with Remote: Update components of segrep backpressure to support remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Adding tests

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
linuxpi pushed a commit to linuxpi/OpenSearch that referenced this pull request Jun 20, 2023
opensearch-project#8020)

* SegRep with Remote: Update components of segrep backpressure to support remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Adding tests

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Jun 26, 2023
opensearch-project#8020)

* SegRep with Remote: Update components of segrep backpressure to support remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Adding tests

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…essure to support remote store. (opensearch-project#8020) (opensearch-project#8066)

* SegRep with Remote: Update components of segrep backpressure to suppo… (opensearch-project#8020)

* SegRep with Remote: Update components of segrep backpressure to support remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>
imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
opensearch-project#8020)

* SegRep with Remote: Update components of segrep backpressure to support remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Adding tests

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
opensearch-project#8020)

* SegRep with Remote: Update components of segrep backpressure to support remote store.

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Adding tests

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants