Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Add logic back to update tracking replication checkpoint on source #8560

Merged
merged 7 commits into from
Jul 11, 2023

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Jul 9, 2023

Description

With #8020, the behavior around how primary tracks replica checkpoint was changed. The change was to rely on replica shard initiating a separate transport call to primary for checkpoint update when segment replication round finishes. This additional network call breaks backward compatibility with released versions where source does not have respective transport handler to update target replication checkpoint and fails with below error

Failed to update visible checkpoint for replica [test-index-segrep][2], ReplicationCheckpoint{shardId=[test-index-segrep][2], primaryTerm=1, segmentsGen=4, version=9, size=230, codec=Lucene95}: RemoteTransportException[[v2.8.1-2][127.0.0.1:36499][internal:index/shard/replication/update_visible_checkpoint]]; nested: ActionNotFoundTransportException[No handler for action [internal:index/shard/replication/update_visible_checkpoint]];

This PR now allows the primary to update the visible ReplicationCheckpoint of replica shards with node-node communication. In current state:

  1. Node-Node communication. Source updates replication checkpoint as part of get_segment_files handling
  2. Remote store. Source expects replica shard to make update_visible_checkpoint transport call.

Related Issues

Resolves #8322
Related: #8202

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…heckpoint on source

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

… update

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89 dreamer-89 merged commit 3d7d33b into opensearch-project:main Jul 11, 2023
7 checks passed
@dreamer-89 dreamer-89 added the backport 2.x Backport to 2.x branch label Jul 11, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8560-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3d7d33bdbc02ec8e363c5394a9d89451f76e979a
# Push it to GitHub
git push --set-upstream origin backport/backport-8560-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8560-to-2.x.

dreamer-89 added a commit to dreamer-89/OpenSearch that referenced this pull request Jul 11, 2023
…heckpoint on source (opensearch-project#8560)

* [Segment Replication] Add logic back to update tracking replication checkpoint on source

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update comment

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Address review comments & mute breaking bwc-test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Stop timer inside try to prevent double stop on timer

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update PressureITs to wait for appropriate transport call for replica update

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

---------

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit 3d7d33b)
dreamer-89 added a commit that referenced this pull request Jul 11, 2023
…heckpoint on source (#8560) (#8633)

* [Segment Replication] Add logic back to update tracking replication checkpoint on source

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update comment

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Address review comments & mute breaking bwc-test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Stop timer inside try to prevent double stop on timer

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update PressureITs to wait for appropriate transport call for replica update

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

---------

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit 3d7d33b)
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…heckpoint on source (opensearch-project#8560)

* [Segment Replication] Add logic back to update tracking replication checkpoint on source

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update comment

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Address review comments & mute breaking bwc-test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Stop timer inside try to prevent double stop on timer

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update PressureITs to wait for appropriate transport call for replica update

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

---------

Signed-off-by: Suraj Singh <surajrider@gmail.com>
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…heckpoint on source (opensearch-project#8560)

* [Segment Replication] Add logic back to update tracking replication checkpoint on source

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update comment

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Address review comments & mute breaking bwc-test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Stop timer inside try to prevent double stop on timer

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update PressureITs to wait for appropriate transport call for replica update

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

---------

Signed-off-by: Suraj Singh <surajrider@gmail.com>
dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
…heckpoint on source (opensearch-project#8560)

* [Segment Replication] Add logic back to update tracking replication checkpoint on source

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update comment

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Address review comments & mute breaking bwc-test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Stop timer inside try to prevent double stop on timer

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update PressureITs to wait for appropriate transport call for replica update

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

---------

Signed-off-by: Suraj Singh <surajrider@gmail.com>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
…heckpoint on source (opensearch-project#8560)

* [Segment Replication] Add logic back to update tracking replication checkpoint on source

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update comment

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Address review comments & mute breaking bwc-test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Stop timer inside try to prevent double stop on timer

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update PressureITs to wait for appropriate transport call for replica update

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

---------

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…heckpoint on source (opensearch-project#8560)

* [Segment Replication] Add logic back to update tracking replication checkpoint on source

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update comment

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Address review comments & mute breaking bwc-test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Stop timer inside try to prevent double stop on timer

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update PressureITs to wait for appropriate transport call for replica update

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

---------

Signed-off-by: Suraj Singh <surajrider@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…heckpoint on source (opensearch-project#8560)

* [Segment Replication] Add logic back to update tracking replication checkpoint on source

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update comment

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Address review comments & mute breaking bwc-test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Stop timer inside try to prevent double stop on timer

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update PressureITs to wait for appropriate transport call for replica update

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check

Signed-off-by: Suraj Singh <surajrider@gmail.com>

---------

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Segment Replication] checkpoints_behind in _cat/segment_replication API does not goes down to 0
2 participants